Add support for Symfony 7, require Symfony 5.4+ and PHP 7.4+ #937
Conversation
|
The lowest deps build is showing that it might be time to start dropping legacy Symfony support. https://github.com/schmittjoh/JMSSerializerBundle/actions/runs/6435785419/job/17477761506?pr=937 fatal'd out because the signature of the cache warmer isn't compatible with Symfony 3.4, and it's typehinted in Symfony 7. |
composer.json
Outdated
| "symfony/framework-bundle": "^3.4 || ^4.0 || ^5.0 || ^6.0" | ||
| "jms/serializer": "^3.28", | ||
| "jms/metadata": "^2.6", | ||
| "symfony/dependency-injection": "^3.4 || ^4.0 || ^5.0 || ^6.0 || ^7.0", |
There was a problem hiding this comment.
it is crazy to see that we are able to run this bundle on a such large range of symfony versions
mbabker
changed the title
mbabker
force-pushed
the
symfony-7
branch
3 times, most recently
from
3fe88b1
to
96779fc
Compare
|
@mbabker Is this PR ready to merge? Please request a contributor review if so. |
|
The current state is reflected in the PR description.
The dependent PR should be reviewed/merged separately, and because of the changes it makes, it is a blocker to allowing this one to be reviewed/merged. |
|
The dependent PR has been merged 🎉 Could you rebase this one and prepare it for review? Thanks so much for your work on this 💙 💪 |
mbabker
changed the title
|
Looks good to me. Could we have a merge here? SymfonyCon' hackday is happening now and we need this to fix other bundles' compatibility. |
Adds Symfony 7 support, WIP as this builds on top of #933 to ensure it works with the annotations support being removed.
Since the first push of this PR failed on the lowest deps build because of incompatible signatures, this will also drop support for Symfony versions before 5.4 (current LTS), and bumps the PHP minimum to 7.4 because according to the Packagist stats the number of folks running a 5.x release of the bundle on PHP 7.2 or 7.3 is so insignificant that at this point it's just more efficient to drop those EOL PHP branches.