Symfony 7 support #1933
Symfony 7 support #1933
Conversation
…d Symfony 7 php version is 8.2 https://symfony.com/releases/7.0
…with support for php 8.*
…e/phpcr-odm version should be used for php 8.3
… doctrine/phpcr-odm version should be used for php 8.3" This reverts commit 22c8a4c.
|
There is an issue with dependencies. |
|
The second reason tests are failing is that |
|
Current PR will be updated after the following PR is merged. |
|
@XWB do you or somebody else be able to check this PR and move it forward? @rusted-love could you check the Code style errors in the CI flow (/ re-push code to re-run the CI which should have the other errors fixed since the mentioned blocked issues are merged)? 🚀 |
|
I can only merge when all pipelines have passed. |
@evertharmeling Yes, doctrine/phpcr-odm#846 was merged a few days ago, but it was not released under next minor version (1.8.0 -> 1.8.1). Still waiting for a release tag to move forward. |
|
What version of PHP-CS-fixer did you use to update the code style? You may need to update the workflow version to prevent it to fail |
|
Hey 👋 @rusted-love Do you still have time/interest to work on this PR? |
@llupa Yes, but I need a community suggestion how to move forward. Should I wait for a stable phpcr-odm v2 release or there is a way to release current PR with beta version of 'phpcr-odm' today? |
I think first it would be great if you can run php-cs-fixer at And dbu asked (in the same PR your linked):
Since you have all this work done, you could switch to their upcoming v2 and see if this pipeline will keep working. I personally would update in this same PR and mark it as Draft just in case. Or if you feel unsure, make another branch out of this branch and try it out. If the tests pass, pinging David will only add reassurance for his ~planned release end of this month. What do you think? @rusted-love |
…ny desired version without the need to update the rest of dependencies.
|
@llupa I've done what you said. There are issues with dependencies again. For some reason composer does not use RC-1 and beta releases. I would be glad to get help again. :) |
Probably due to not having ...
"minimum-stability": "RC",
"prefer-stable": true,
...This should do the trick, allowing specific |
* Update dependencies * add php 8.3 * add symfony 7 to tests * exclude php 7.4 from tests for symfony 7 * Exclude all php versions prior to 8.2 for Symfony 7. Minimum supported Symfony 7 php version is 8.2 https://symfony.com/releases/7.0 * Require minimum doctrine/phpcr-odm 1.5.3. This is the lowest version with support for php 8.* * Exclude php 8.3 symfony 7 lowest dependencies from CI. Higher doctrine/phpcr-odm version should be used for php 8.3 * Revert "Exclude php 8.3 symfony 7 lowest dependencies from CI. Higher doctrine/phpcr-odm version should be used for php 8.3" This reverts commit 22c8a4c. * Run cs fixer * fix code style * fix a suddenly excluded case * Lock to symfony/console@^6.1 because of issue with doctrine/phpcr-odm as described in #1933 (comment) * run cs fixer * Bump jms/serializer-bundle to v5 * Remove jms/serializer-bundle v3 support because php 7.2 has reached an end of life https://www.php.net/supported-versions.php * add php 8.3 to phpstan * Update all Symfony references to ^6.3 * Add symfony/console 7.0 to dependencies. * Normalize continuous integration matrix. * Normalize continuous integration matrix. * update gitignore * fix gitignore * fix typo * Replace php-cs-fixer with a shim version. It allows us to lock with any desired version without the need to update the rest of dependencies. * Run php-cs-fixer with locked version 3.8.0. * Add support for doctrine/phpcr-odm 2-beta release. * Cs fixer fix * Bump knplabs/knp-components * Fix php cs fixer version. * CS Fixer fixes with version 3.8.0. * Add symfony/stopwatch because it's required by project * Bumb jackalope/jackalope-doctrine-dbal to RC-1 * Normalize composer * Disable symfony testing with php 8.2 and 8.3 * minimum stability RC * [cs] Fix composer.json * [phpunit] Fix 'framework.annotations' error * [phpunit] Fix 'getAliasNamespace' error * [phpunit] Not use CodeExtension anymore * [phpunit] Variable 'profile_type' does not exist * Make use of 'AsMessageHandler' attribute in favor of MessageHandlerInterface + dropped support for SF 4.4 (as AsMessageHandler is available in SF 5.4) * [phpstan] Excluded AsyncPersistPageHandler as attributes are not supported * [phpstan] Fix ContainerAwareInterface not found --------- Co-authored-by: Liakhovskyi Vladyslav <vlad@revotale.com> Co-authored-by: Liakhovskyi Vladyslav <rusted@revotale.com>
|
This issue may be closed due to the merge of #1938 |
|
Closing in favor of #1938 |
* Update dependencies * add php 8.3 * add symfony 7 to tests * exclude php 7.4 from tests for symfony 7 * Exclude all php versions prior to 8.2 for Symfony 7. Minimum supported Symfony 7 php version is 8.2 https://symfony.com/releases/7.0 * Require minimum doctrine/phpcr-odm 1.5.3. This is the lowest version with support for php 8.* * Exclude php 8.3 symfony 7 lowest dependencies from CI. Higher doctrine/phpcr-odm version should be used for php 8.3 * Revert "Exclude php 8.3 symfony 7 lowest dependencies from CI. Higher doctrine/phpcr-odm version should be used for php 8.3" This reverts commit 22c8a4c. * Run cs fixer * fix code style * fix a suddenly excluded case * Lock to symfony/console@^6.1 because of issue with doctrine/phpcr-odm as described in FriendsOfSymfony#1933 (comment) * run cs fixer * Bump jms/serializer-bundle to v5 * Remove jms/serializer-bundle v3 support because php 7.2 has reached an end of life https://www.php.net/supported-versions.php * add php 8.3 to phpstan * Update all Symfony references to ^6.3 * Add symfony/console 7.0 to dependencies. * Normalize continuous integration matrix. * Normalize continuous integration matrix. * update gitignore * fix gitignore * fix typo * Replace php-cs-fixer with a shim version. It allows us to lock with any desired version without the need to update the rest of dependencies. * Run php-cs-fixer with locked version 3.8.0. * Add support for doctrine/phpcr-odm 2-beta release. * Cs fixer fix * Bump knplabs/knp-components * Fix php cs fixer version. * CS Fixer fixes with version 3.8.0. * Add symfony/stopwatch because it's required by project * Bumb jackalope/jackalope-doctrine-dbal to RC-1 * Normalize composer * Disable symfony testing with php 8.2 and 8.3 * minimum stability RC * [cs] Fix composer.json * [phpunit] Fix 'framework.annotations' error * [phpunit] Fix 'getAliasNamespace' error * [phpunit] Not use CodeExtension anymore * [phpunit] Variable 'profile_type' does not exist * Make use of 'AsMessageHandler' attribute in favor of MessageHandlerInterface + dropped support for SF 4.4 (as AsMessageHandler is available in SF 5.4) * [phpstan] Excluded AsyncPersistPageHandler as attributes are not supported * [phpstan] Fix ContainerAwareInterface not found --------- Co-authored-by: Liakhovskyi Vladyslav <vlad@revotale.com> Co-authored-by: Liakhovskyi Vladyslav <rusted@revotale.com>
Fixes #1932. Add PHP 8.3 tests.
This PR replaces #1931 and #1930.