Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deps on symfony/config #942

Closed
wants to merge 1 commit into from

Conversation

niconoe-
Copy link

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? not checked, but as the dependency is already downloaded from another lib, I 99.99% expect "yes"
Fixed tickets #941
License MIT

Fixes #941 as long as a new patch is released soon after.

Unecessary if a new JMSSerializerBundle version compatible with Symfony 7 is released earlier.

@mbabker
Copy link
Contributor

mbabker commented Nov 29, 2023

This is now incorporated into #937 (I'd say the odds of this being merged and released on its own are pretty low).

@niconoe-
Copy link
Author

This is now incorporated into #937 (I'd say the odds of this being merged and released on its own are pretty low).

100% agree about releasing a new patch just for this is pointless if #937 will be integrated and its changes released soon. Thanks a lot, and crossing fingers that next release will be soon 😉 .

@goetas
Copy link
Collaborator

goetas commented Dec 12, 2023

done in #937

@goetas goetas closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing explicitly used dependency with symfony/config, cause fatal error
3 participants