Fix test regression caused by node fixing CVE-2024-27980 #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a test-only fix:
sass-embedded >=1.59.2
is not affected because in production release we always launch thedart.exe
directly since this commit: 3088620sass-embedded <1.59.2
would be broken if a windows user upgrades to the latest node with the fix for the CVE. There is no security risk forsass-embedded
itself even if a windows user uses a vulnerable version of node, because we don't have any arguments when launching.bat
, thus there is no risk of injection with in this project. However, there might be attack factors in other node dependencies, therefore, it is recommended for windows users to upgrade to latest node andsass-embedded >=1.59.2
..bat
wrapper in the test, this is now blocked with the CVE fix. This PR fixes this case by addingshell: true
.