Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test regression caused by node fixing CVE-2024-27980 #286

Merged
merged 1 commit into from Apr 12, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Apr 12, 2024

This is mainly a test-only fix:

  • sass-embedded >=1.59.2 is not affected because in production release we always launch the dart.exe directly since this commit: 3088620
  • sass-embedded <1.59.2 would be broken if a windows user upgrades to the latest node with the fix for the CVE. There is no security risk for sass-embedded itself even if a windows user uses a vulnerable version of node, because we don't have any arguments when launching .bat, thus there is no risk of injection with in this project. However, there might be attack factors in other node dependencies, therefore, it is recommended for windows users to upgrade to latest node and sass-embedded >=1.59.2.
  • Test is broken because we use the .bat wrapper in the test, this is now blocked with the CVE fix. This PR fixes this case by adding shell: true.

@nex3 nex3 merged commit fd32e8e into sass:main Apr 12, 2024
16 checks passed
@ntkme ntkme deleted the cve-2024-27980 branch April 12, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants