Implement access tracking for containingUrl #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
force-pushed
the
main
branch
3 times, most recently
from
7e7a586
to
ea4cbd8
Compare
|
Looks like yesterday's node 20.12.2 is breaking our test on windows: nodejs/node@69ffc6d50d |
|
@nex3 I added a commit to fix the node regression. Regarding CVE-2024-27980:
|
|
Can you pull the CVE fix into a separate PR? |
nex3
requested changes
Apr 12, 2024
lib/src/importer-registry.ts
Outdated
| * it's not part of the package's public API and should not be accessed by | ||
| * user code. It may be renamed or removed without warning in the future. | ||
| */ | ||
| containingUrlAccessed = false; |
There was a problem hiding this comment.
Make this field private and give it a public getter, so it's clear that only this class should ever modify it.
There was a problem hiding this comment.
Updated. I also made the same change for ArugmentList, which is where I copied the pattern.
nex3
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sass/sass#3835
sass/dart-sass#2220