Fix test regression caused by node fixing CVE-2024-27980 (#286)

sass · Apr 19, 2024 · 6e9368e · 6e9368e
1 parent 625e11d
commit 6e9368e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/src/compiler/async.ts b/lib/src/compiler/async.ts
@@ -43,6 +43,10 @@ export class AsyncCompiler {
       // current working directory.
       // https://github.com/sass/embedded-host-node/pull/261#discussion_r1438712923
       cwd: path.dirname(compilerCommand[0]),
+      // Node blocks launching .bat and .cmd without a shell due to CVE-2024-27980
+      shell: ['.bat', '.cmd'].includes(
+        path.extname(compilerCommand[0]).toLowerCase()
+      ),
       windowsHide: true,
     }
   );

diff --git a/lib/src/compiler/sync.ts b/lib/src/compiler/sync.ts
@@ -43,6 +43,10 @@ export class Compiler {
       // current working directory.
       // https://github.com/sass/embedded-host-node/pull/261#discussion_r1438712923
       cwd: path.dirname(compilerCommand[0]),
+      // Node blocks launching .bat and .cmd without a shell due to CVE-2024-27980
+      shell: ['.bat', '.cmd'].includes(
+        path.extname(compilerCommand[0]).toLowerCase()
+      ),
       windowsHide: true,
     }
   );