Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call super() in a bunch of initializers #359

Merged
merged 1 commit into from Jun 22, 2022
Merged

Call super() in a bunch of initializers #359

merged 1 commit into from Jun 22, 2022

Conversation

eddierubeiz
Copy link
Contributor

Lint/MissingSuper wants us to call super() at the beginning of these initializers.

I'm mindful of the discussion at rubocop/ruby-style-guide#809 but this looks to me like a harmless change.

@eddierubeiz eddierubeiz self-assigned this Jun 22, 2022
@eddierubeiz eddierubeiz mentioned this pull request Jun 22, 2022
Closed
@jrochkind
Copy link
Contributor

The superclass(es) involved (mostly/all Qa::Authorities::Base?) doesn't seem to HAVE an initializer defined... I don't think this does anything... but if future rubocop is going to require it (once we add more ruby versions), which I think is where these come from, I guess our job is to satisfy rubocop?

@jrochkind jrochkind merged commit 1b6e13d into samvera:main Jun 22, 2022
@eddierubeiz eddierubeiz mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrochkind jrochkind jrochkind approved these changes

Assignees

@eddierubeiz eddierubeiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddierubeiz @jrochkind