Merge pull request #359 from eddierubeiz/initialize_superclass

Call `super()` in a bunch of initializers
samvera · Jun 22, 2022 · 1b6e13d · 1b6e13d
2 parents bfae87d + 2dd48a6
commit 1b6e13d
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 0 deletions.
diff --git a/lib/qa/authorities/assign_fast/generic_authority.rb b/lib/qa/authorities/assign_fast/generic_authority.rb
@@ -4,7 +4,9 @@ module Qa::Authorities
   # http://www.oclc.org/developer/develop/web-services/fast-api/assign-fast.en.html
   class AssignFast::GenericAuthority < Base
     attr_reader :subauthority
+
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
 

diff --git a/lib/qa/authorities/crossref/generic_authority.rb b/lib/qa/authorities/crossref/generic_authority.rb
@@ -5,6 +5,7 @@ class Crossref::GenericAuthority < Base
     attr_reader :subauthority
 
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
 

diff --git a/lib/qa/authorities/discogs/generic_authority.rb b/lib/qa/authorities/discogs/generic_authority.rb
@@ -11,6 +11,7 @@ class Discogs::GenericAuthority < Base
 
     # @param [String] subauthority to use
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
       self.primary_artists = []
       self.work_uri = "workn1"

diff --git a/lib/qa/authorities/linked_data/generic_authority.rb b/lib/qa/authorities/linked_data/generic_authority.rb
@@ -20,6 +20,7 @@ class GenericAuthority < Base
       delegate :subauthority?, :subauthorities?, to: :search_config, prefix: 'search'
 
       def initialize(auth_name)
+        super()
         @authority_config = Qa::Authorities::LinkedData::Config.new(auth_name)
       end
 

diff --git a/lib/qa/authorities/loc/generic_authority.rb b/lib/qa/authorities/loc/generic_authority.rb
@@ -2,6 +2,7 @@ module Qa::Authorities
   class Loc::GenericAuthority < Base
     attr_reader :subauthority
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
 

diff --git a/lib/qa/authorities/local/file_based_authority.rb b/lib/qa/authorities/local/file_based_authority.rb
@@ -2,6 +2,7 @@ module Qa::Authorities
   class Local::FileBasedAuthority < Base
     attr_reader :subauthority
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
 

diff --git a/lib/qa/authorities/local/table_based_authority.rb b/lib/qa/authorities/local/table_based_authority.rb
@@ -34,6 +34,7 @@ def table_or_view_exists?
     attr_reader :subauthority
 
     def initialize(subauthority)
+      super()
       self.class.check_for_index
       @subauthority = subauthority
     end

diff --git a/lib/qa/authorities/oclcts/generic_oclc_authority.rb b/lib/qa/authorities/oclcts/generic_oclc_authority.rb
@@ -3,6 +3,7 @@ class Oclcts::GenericOclcAuthority < Base
     attr_reader :subauthority
 
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
     include WebServiceBase

diff --git a/spec/controllers/terms_controller_spec.rb b/spec/controllers/terms_controller_spec.rb
@@ -65,6 +65,7 @@
         class Qa::Authorities::Local::TwoArgs < Qa::Authorities::Base
           attr_reader :subauthority
           def initialize(subauthority)
+            super()
             @subauthority = subauthority
           end