Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support for Rails 3.0 and 3.1 #365

Closed
wants to merge 3 commits into from
Closed

[WIP] Support for Rails 3.0 and 3.1 #365

wants to merge 3 commits into from

Conversation

eddierubeiz
Copy link
Contributor

@eddierubeiz eddierubeiz commented Jun 22, 2022 •
edited

  • Adds limited support for Ruby 3.0 and 3.1.
  • Turns off Style/HashSyntax rubocop for now.
  • Three changes are made to the enginecart test app to support the combo of Ruby 3 and Rails 6:
    • Opts into 'mail', '>= 2.8.0.rc1'
    • Holds backpsych < 4
    • Adds gem 'net-smtp', require: false
  • No attempt is made to get Ruby 3 working with Rails 5, per comment Support Ruby 3.1.3 releases maintenance#81 (comment) .

@jrochkind jrochkind mentioned this pull request Jun 23, 2022
Closed
@eddierubeiz eddierubeiz changed the title WIP 3.1 changes to ci config and qa.gemspec [WIP] 3.1 changes to ci config and qa.gemspec Jun 24, 2022
@eddierubeiz
pin psych to < 4 in test app
0b6261b 
add bixby so rubocop tests will run
update readme re: compatibility
target ruby 3.1 in rubocop linting
updating ci test settings to include 3.1
@eddierubeiz eddierubeiz changed the title [WIP] 3.1 changes to ci config and qa.gemspec [WIP] Support for 3.0 and 3.1 Jul 7, 2022
@eddierubeiz eddierubeiz changed the title [WIP] Support for 3.0 and 3.1 [WIP] Support for Rails 3.0 and 3.1 Jul 7, 2022
@eddierubeiz
Copy link
Contributor Author

Closing in favor of a branch that doesn't involve my forked repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eddierubeiz