Test with php 7.3 #424
Merged
Test with php 7.3 #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepDiver1975
force-pushed
the
feature/php7.3
branch
2 times, most recently
from
e0b0626
to
ea7a15c
Compare
|
@staabm seems like there is no way to test with the current travis config on php 5.5 I vote for removing php 5.5 from travis for now - later we can decide to drop it completly ... Objections? |
|
I am ok with a "allow failures" travis config for php5.5 (and a separate issue in the issue tracker to maybe solve this problem in the future) |
staabm
reviewed
Sep 25, 2018
.travis.yml
Outdated
| addons: | ||
| apt: | ||
| packages: | ||
| - libzip4 |
There was a problem hiding this comment.
add a comment when/why we need this
DeepDiver1975
force-pushed
the
feature/php7.3
branch
from
85243f5
to
2f5f131
Compare
|
Why don't you cut a new major version and drop PHP < 7? Might make your life a bit easier. |
DeepDiver1975
force-pushed
the
feature/php7.3
branch
from
2f5f131
to
7e906bc
Compare
DeepDiver1975
force-pushed
the
feature/php7.3
branch
from
7e906bc
to
f3cc955
Compare
|
We can drop older version in a followup pr. @staabm merge? We can then tag a new alpha and setup dependencies in other repos properly. |
|
Thanks |
|
4.2.0. when we dont drop php5, agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.