Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with php 7.3 #424

Merged
merged 2 commits into from Sep 25, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion .travis.yml
@@ -1,12 +1,19 @@
language: php
sudo: required
dist: xenial
php:
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2
- 7.3snapshot

sudo: false
addons:
apt:
packages:
# required for php7.3
- libzip4

script:
- ./bin/phpunit --configuration tests/phpunit.xml
Expand All @@ -18,3 +25,7 @@ before_script:
cache:
directories:
- $HOME/.composer/cache

matrix:
allow_failures:
- php: 5.5
2 changes: 1 addition & 1 deletion lib/Component/VCard.php
Expand Up @@ -511,7 +511,7 @@ function xmlSerialize(Xml\Writer $writer) {
switch ($property->name) {

case 'VERSION':
continue;
break;

case 'XML':
$value = $property->getParts();
Expand Down
2 changes: 1 addition & 1 deletion lib/FreeBusyGenerator.php
Expand Up @@ -430,7 +430,7 @@ protected function calculateBusy(FreeBusyData $fbData, array $objects) {
// instance. We are skipping this event from the output
// entirely.
unset($this->objects[$key]);
continue;
break;
}

if ($this->start) {
Expand Down
4 changes: 2 additions & 2 deletions tests/VObject/BirthdayCalendarGeneratorTest.php
Expand Up @@ -475,11 +475,11 @@ function testVcardStringWithEmptyBirthdayProperty() {
function testParseException() {

$generator = new BirthdayCalendarGenerator();
$input = <<<FOO
$input = <<<EOT
BEGIN:FOO
FOO:Bar
END:FOO
FOO;
EOT;

$generator->setObjects($input);

Expand Down