Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 7.3 compatibility (#422) #423

Closed
wants to merge 2 commits into from
Closed

Fix PHP 7.3 compatibility (#422) #423

wants to merge 2 commits into from

Conversation

alecpl
Copy link
Contributor

@alecpl alecpl commented Sep 21, 2018

No description provided.

@alecpl alecpl mentioned this pull request Sep 21, 2018
Closed
@renaudboyer
Copy link
Contributor

continue in switch direct replacement is break. continue 2 changes behavior, although it's working here because of the code structure.

@alecpl
Copy link
Contributor Author

alecpl commented Sep 25, 2018

Indeed it looks that in these cases just break is fine. Changed.

@DeepDiver1975
Copy link
Member

assimilated into #424 - Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alecpl @renaudboyer @DeepDiver1975