Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for stable10 on PHP 7.3 #34084

Closed
wants to merge 1 commit into from
Closed

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 8, 2019

Unit tests:

1) OCA\DAV\Tests\unit\ServerTest::test with data set "principals" ('principals/users/admin', array('caldav', 'oc-resource-sharing', 'carddav'))
ErrorException: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

/drone/src/lib/composer/sabre/dav/lib/CalDAV/ICSExportPlugin.php:321
/drone/src/apps/dav/lib/Server.php:160
/drone/src/apps/dav/tests/unit/ServerTest.php:45

Is fixed by sabre-io/dav#1080 which is in sabre/dav 4.0.0-alpha5

2) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testUpdateProperties
ErrorException: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

/drone/src/lib/composer/sabre/vobject/lib/Component/VCard.php:514
/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:381

(8 of these)
Are fixed by sabre-io/vobject#424 which is in sabre/vobject 4.2.0-alpha1 which is a dependency for sabre/dav 4.0.0-alpha5
So that would need backporting to some version combination that will support PHP 5.6

@phil-davis phil-davis self-assigned this Jan 8, 2019
@phil-davis
Copy link
Contributor Author

Good to know the above things that currently prevent PHP 7.3 from passing in stable10
@DeepDiver1975 FYI, I guess at some point we will want to support PHP 7.3 with stable10 ?
And so these sabre changes will need to be released as patches in versions of sabre libraries that also are happy to co-exist with PHP5.6

@phil-davis phil-davis closed this Jan 9, 2019
@phil-davis phil-davis deleted the stable10-test-php-7.3 branch January 9, 2019 10:39
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant