Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AIX operating system #2894

Merged
merged 1 commit into from Feb 22, 2023
Merged

Support AIX operating system #2894

merged 1 commit into from Feb 22, 2023

Conversation

ecnelises
Copy link
Contributor

@ecnelises ecnelises commented Aug 31, 2022

This PR adds rather complete definitions and declarations from AIX system headers, with little modification to fit the assumption in some crates or other targets in libc.

Currently only 64-bit PowerPC targets on AIX are proposed, so definitions depending on pointer width are located in powerpc64 module.

This one should be successor of #2278 (and thanks to @EGuesnet 's initial work).

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

src/unix/aix/mod.rs Outdated Show resolved Hide resolved
src/unix/aix/powerpc64.rs Show resolved Hide resolved
src/unix/aix/mod.rs Outdated Show resolved Hide resolved
src/unix/aix/mod.rs Show resolved Hide resolved
src/unix/aix/mod.rs Outdated Show resolved Hide resolved
@JohnTitor
Copy link
Member

Also, please fix the style check failure.

@ecnelises ecnelises requested a review from bzEq September 8, 2022 02:32
@JohnTitor
Copy link
Member

Marking as blocked until rust-lang/compiler-team#553 is approved.
Squash commits into one once it's ready.

@bors
Copy link
Contributor

bors commented Dec 20, 2022

☔ The latest upstream changes (presumably #3038) made this pull request unmergeable. Please resolve the merge conflicts.

@ecnelises
Copy link
Contributor Author

Can we push this forward now? (since this is essential crate for nearly all crates)

@workingjubilee
Copy link
Contributor

The last request was

Squash commits into one once it's ready.

So if you take care of that last bit I can make sure this happens!

This change adds rather complete definitions and declarations from AIX
system headers, with little modification to fit the assumption in some
crates or other targets in libc.

Currently only 64-bit PowerPC targets on AIX are proposed, so
definitions depending on pointer width are located in powerpc64 module.

Thanks to initial work from Etienne Guesnet, this patch is based on it
(rust-lang#2278).
@ecnelises
Copy link
Contributor Author

The last request was

Squash commits into one once it's ready.

So if you take care of that last bit I can make sure this happens!

Ah, thanks. I thought this would be done by the GitHub button.

@workingjubilee
Copy link
Contributor

Well everyone has different feelings about how that should go, but mostly, bors does the merges around here! And since all the requirements laid out were fulfilled, I am happy to be DoppelTitor. I think I have the authority to do that now.

@bors r=JohnTitor

@bors
Copy link
Contributor

bors commented Feb 22, 2023

📌 Commit f53a099 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 22, 2023

⌛ Testing commit f53a099 with merge 7489657...

@workingjubilee
Copy link
Contributor

Aha, I do!
Thank you for your contribution!

@bors
Copy link
Contributor

bors commented Feb 22, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 7489657 to master...

@bors bors merged commit 7489657 into rust-lang:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants