Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AIX operating system #1823

Merged
merged 1 commit into from Aug 6, 2023
Merged

Support AIX operating system #1823

merged 1 commit into from Aug 6, 2023

Conversation

ecnelises
Copy link
Contributor

No description provided.

@rtzoeller
Copy link
Collaborator

Is AIX supported by rustc as a tier 3 compiler? I don't see it in https://doc.rust-lang.org/nightly/rustc/platform-support.html.

That's generally a prerequisite for adding support to nix, as we otherwise can't guarantee compilation won't be broken by subsequent PRs.

@SteveLauC
Copy link
Member

Is AIX supported by rustc as a tier 3 compiler? I don't see it in https://doc.rust-lang.org/nightly/rustc/platform-support.html.

A proposal has been filed by the author.

@ecnelises
Copy link
Contributor Author

Is AIX supported by rustc as a tier 3 compiler? I don't see it in https://doc.rust-lang.org/nightly/rustc/platform-support.html.

That's generally a prerequisite for adding support to nix, as we otherwise can't guarantee compilation won't be broken by subsequent PRs.

Understand. rust-lang/compiler-team#553 has not been accepted yet, so I keep this PR in draft status. 😊

@rtzoeller
Copy link
Collaborator

Understand. rust-lang/compiler-team#553 has not been accepted yet, so I keep this PR in draft status. 😊

It looks like that PR is accepted; is this change now waiting on rust-lang/libc#2894?

@ecnelises ecnelises marked this pull request as ready for review December 6, 2022 10:43
@ecnelises
Copy link
Contributor Author

It looks like that PR is accepted; is this change now waiting on rust-lang/libc#2894?

Yes, this depends on libc. But rustc can recognize aix target now, so this change should not cause warnings.

@thegreystone
Copy link

Hi! Can this one be merged now?

@ecnelises
Copy link
Contributor Author

Yes, this is ready and built successfully on AIX system. Since rustup does not support AIX yet, I will add CI stuff in the future.

@ecnelises
Copy link
Contributor Author

Hi, is this ready to be checked-in now?

@asomers
Copy link
Member

asomers commented Jul 15, 2023

You should rebase to fix the CI errors.

asomers
asomers approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI errors are all fixed. Bors will find out.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 6, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 53b0332 into nix-rust:master Aug 6, 2023
35 of 40 checks passed
@ecnelises
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ecnelises @rtzoeller @SteveLauC @thegreystone @asomers