Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AIX support #2278

Closed
wants to merge 1 commit into from
Closed

Add AIX support #2278

wants to merge 1 commit into from

Conversation

EGuesnet
Copy link

@EGuesnet EGuesnet commented Jul 8, 2021

Minimal PR to build std library with AIX as a target. This target is not yet official in rust.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@Amanieu
Copy link
Member

Amanieu commented Jul 9, 2021

I don't feel familiar enough with libc to review this.

r? @JohnTitor

@rust-highfive rust-highfive assigned JohnTitor and unassigned Amanieu Jul 9, 2021
@JohnTitor
Copy link
Member

Hey, thanks for the PR!
Could you clarify the context here? And if you have a custom std build, maybe it's enough to have a "patched" libc dependency.

@EGuesnet
Copy link
Author

I am porting Rust to AIX. I have cross-compil libstd, libcore... on Linux with AIX as a target.
It is hard to reproduce because it needs a patched LLVM (all patchs are reported), a patched Rust compiler (not cleaned enough to be reported yet), an AIX server and some patched Rust libraries.

I report my patches about Rust libraries. This PR contains all libc patches I use to cross-compil std to AIX.

@JohnTitor
Copy link
Member

So, you're currently compiling std and related stuff fine with your own patched libc, right? If you have a plan to add an official target, then you should follow the step like rust-lang/rust#86191.

@EGuesnet
Copy link
Author

Thanks.
I plan to add an official target, but I need LLVM 13 at least (in October 2021), or probably LLVM 14.
I also have some compiler workaround, too ugly to be reported now.

If you want PR to be accepted in the same time for libc and compiler, I propose to transform this one as a draft. So, it is public if someone searches information about RUST on AIX.

@EGuesnet EGuesnet marked this pull request as draft July 13, 2021 11:01
@JohnTitor
Copy link
Member

If you want PR to be accepted in the same time for libc and compiler, I propose to transform this one as a draft. So, it is public if someone searches information about RUST on AIX.

Yeah, sounds good.

@bzEq
Copy link
Contributor

bzEq commented Jan 4, 2022

Hi any progress on supporting rust on AIX? Looks it's not updated for couple of months and LLVM-13.0.0 is released.

@EGuesnet
Copy link
Author

Hi any progress on supporting rust on AIX? Looks it's not updated for couple of months and LLVM-13.0.0 is released.

Hi,
I have not made any progress on the Rust port. My team is no longer working on Rust anymore. I will give news on who will be working on this as soon as I know.

@danieu-il
Copy link

Hi, I have also a project where I need to use rust on AS400 or AIX, but stucked with no option. There is any news?

@EGuesnet
Copy link
Author

Hi @danieu-il,
Sorry, but Rust port on AIX is totally frozen as far as I know. If you have a contract with IBM, you can contact them.
You can also contact the AIX OpenSource team on https://community.ibm.com/community/user/power/communities/community-home?CommunityKey=10c1d831-47ee-4d92-a138-b03f7896f7c9 .

@ecnelises
Copy link
Contributor

Hi @EGuesnet , I proposed change (rust-lang/compiler-team#553 ) to add AIX support in Rust toolchain. Since your focus are not on this any more, can we take over this PR and proceed by future patches?

@EGuesnet
Copy link
Author

Hi @ecnelises,
You can take over this PR. I think this one is clean and mostly OK.
I wish you the best to achieve porting Rust to AIX!

@ecnelises ecnelises mentioned this pull request Aug 31, 2022
Merged
@ecnelises
Copy link
Contributor

I submitted #2894 as successor to this one. Thanks!

@JohnTitor
Copy link
Member

Closing in favor of #2278

@JohnTitor JohnTitor closed this Sep 12, 2022
ecnelises added a commit to ecnelises/libc that referenced this pull request Feb 22, 2023
@ecnelises
Support AIX operating system
f53a099 
This change adds rather complete definitions and declarations from AIX
system headers, with little modification to fit the assumption in some
crates or other targets in libc.

Currently only 64-bit PowerPC targets on AIX are proposed, so
definitions depending on pointer width are located in powerpc64 module.

Thanks to initial work from Etienne Guesnet, this patch is based on it
(rust-lang#2278).
bors added a commit that referenced this pull request Feb 22, 2023
@bors
Auto merge of #2894 - ecnelises:aix, r=JohnTitor
7489657 
Support AIX operating system

This PR adds rather complete definitions and declarations from AIX system headers, with little modification to fit the assumption in some crates or other targets in libc.

Currently only 64-bit PowerPC targets on AIX are proposed, so definitions depending on pointer width are located in `powerpc64` module.

This one should be successor of #2278 (and thanks to `@EGuesnet` 's initial work).
tatref pushed a commit to tatref/libc that referenced this pull request Mar 20, 2023
@ecnelises @tatref
Support AIX operating system
294b647 
This change adds rather complete definitions and declarations from AIX
system headers, with little modification to fit the assumption in some
crates or other targets in libc.

Currently only 64-bit PowerPC targets on AIX are proposed, so
definitions depending on pointer width are located in powerpc64 module.

Thanks to initial work from Etienne Guesnet, this patch is based on it
(rust-lang#2278).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JohnTitor JohnTitor

Labels
S-blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@EGuesnet @rust-highfive @Amanieu @JohnTitor @bzEq @danieu-il @ecnelises