[Fix #7686] Add new JUnitFormatter
#7701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#7686. This PR Adds new `JUnitFormatter` formatter based on rubocop-junit-formatter gem. https://github.com/mikian/rubocop-junit-formatter And this PR includes the following patch to implementation of `JUnitFormatter`. mikian/rubocop-junit-formatter#11. REXML gem has been bundled gem since Ruby 2.8.0-dev (Ruby 3.0), it is added to depend on gemspec. - https://bugs.ruby-lang.org/issues/16485 - ruby/ruby@c3ccf23
koic
force-pushed
the
add_new_junit_formatter
branch
from
e85a04a
to
59cd0f7
Compare
|
I guess we should also mention it in the docs. |
|
Are the following document not enough? |
|
My bad. Didn't see where this was when I went over the changes. |
Closed
koic
added a commit
that referenced
this pull request
Apr 29, 2022
Follow up #10572. REXML dependency was introduced in #7701. It makes sense to specify the latest secure REXML version 3.2.5 or higher: https://www.ruby-lang.org/en/news/2021/04/05/xml-round-trip-vulnerability-in-rexml-cve-2021-28965/ And it would be clearer to specify `>= X.Y.Z` and `<= X.Y` than to use `~> X.Y` and `>= X.Y.Z` when it comes to protected semantic MAJOR version with required minimum PATCH version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7686.
This PR Adds new
JUnitFormatterformatter based on rubocop-junit-formatter gem.https://github.com/mikian/rubocop-junit-formatter
And this PR includes the following patch to implementation of
JUnitFormatter.mikian/rubocop-junit-formatter#11.
REXML gem has been bundled gem since Ruby 2.8.0-dev (Ruby 3.0), it is added to depend on gemspec.
Cc @mikian
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.