New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JUnit formatter #7303
Comments
What would be an example of such a CI tool? |
not to say it's the only format supported but Jenkins can be configured to
use it
…On Thu, 22 Aug 2019 at 05:37 Andreas Bühmann ***@***.***> wrote:
What would be an example of such a CI tool?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7303>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOVFKVX3GZ2CU4TQTCEC23QFYJXZANCNFSM4IONV7VQ>
.
|
Same for AppVeyor: https://www.appveyor.com/docs/running-tests/#uploading-xml-test-results |
There is a |
I've tried it and it works fine, but I think it still makes sense to
consider having support for it on the rubocop gem and not rely on other
gems.
…On Thu, 12 Sep 2019 at 20:34 Ryan Rosenblum ***@***.***> wrote:
There is a rubocop-junit-formatter
<https://github.com/mikian/rubocop-junit-formatter> gem that can be used
until we add the formatter into core RuboCop. I've never used the gem, but
it should work. It will also give us a good baseline for how to implement
the formatter.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7303>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOVFKR2N5SGYYSFW4XPW23QJKKTLANCNFSM4IONV7VQ>
.
|
Thanks for confirming that the gem does work. I agree that this looks like something that can and should be supported by RuboCop itself. The junit formatter is a commonly accepted format. It looks like we would not want to take the implementation directly from the gem. There are several reports of the issues where the formatter is slow or misses some offenses. There is a PR that aimed to fix this, but it was never merged in. Still better to have a starting place than nothing at all. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding! |
This issue has been closed by #7701. |
Some CI tools expect test results to be formatted as JUnit XML. It would be interesting to support this for rubocop Cop results so we can add a step in the pipeline to check for rubocop offenses.
Solution
Include a JUnit formatter in rubocop
The text was updated successfully, but these errors were encountered: