Chore/upgrade rubocop #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iusztin
force-pushed
the
chore/upgrade-rubocop
branch
from
42b4a9f
to
f770b81
Compare
|
@hiroara Is there some place on GH where we could disable the Ruby-23 check? I can't see the setting. Could it be access restricted? |
|
@NEWROPE/dev I disabled the Ruby 2.3 check. This PR is ready for review. Please take a look :) |
hiroara
requested changes
Sep 7, 2020
iusztin
commented
Sep 9, 2020
| - and | ||
|
|
||
| RSpec/MultipleMemoizedHelpers: | ||
| Max: 7 |
There was a problem hiding this comment.
Since we use a lot of let in this project, I chose 7 to avoid most of our use cases (default is 5) and applied code changes to the rest.
For more details about this change by Rubocop-Rspec:
- rubocop/rubocop-rspec#863
- rubocop/rubocop-rspec#862
- https://thoughtbot.com/blog/lets-not
|
@NEWROPE/dev I pushed changes. Please take a look again :) (Though dependabot seems to be stuck at WIP? lol) |
hiroara
reviewed
Sep 10, 2020
| @@ -24,4 +23,6 @@ Gem::Specification.new do |spec| | |||
| spec.require_paths = ['lib'] | |||
|
|
|||
| spec.add_development_dependency 'bundler', '~> 2.1' | |||
|
|
|||
| spec.required_ruby_version = '>= 2.4' | |||
There was a problem hiding this comment.
Thank you for adding this constraint :)
hiroara
approved these changes
Sep 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hiroara @NEWROPE/dev
To deal with:
Also Rubocop started to support its own JUNIT formatter, and the old one was deprecated:
JUnitFormatterrubocop/rubocop#7701So I replaced that too.
And support for Ruby 2.3 was dropped too:
Please review.