Further cop name standardisation #7468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! 🙇 @rubocop-hq/rubocop-core Any feedback/objections from anyone? |
|
Just one small thing - probably we should use |
|
@scottmatthewman ping :-) |
|
Sorry, have been caught up with work related issues but getting back into this over the weekend!
…On 2 Nov 2019, 07:21 +0000, Bozhidar Batsov ***@***.***>, wrote:
@scottmatthewman ping :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
The new naming scheme for cops conflicts with the `HashAlignment` mixin, so that is renamed `HashAlignmentStyles`. Technically it's only used in one place so needn't even be a mixin, but making the smallest change possible for now.
We had a mix of end-of-line disable comments and disable/enable blocks. All are now changed to end-of-line comments.
They're still the same cops, just with different names. See #7468 (comment)
|
|
bbatsov
pushed a commit
that referenced
this pull request
Nov 2, 2019
They're still the same cops, just with different names. See #7468 (comment)
|
Thanks! 🙇 🎉 🚀 |
sue445
added a commit
to sue445/onkcop
that referenced
this pull request
Nov 27, 2019
…Naming/MethodParameterName` since rubocop 0.77.0 c.f. rubocop/rubocop#7468
sue445
added a commit
to sue445/onkcop
that referenced
this pull request
Nov 27, 2019
…Naming/MethodParameterName` since rubocop 0.77.0 c.f. rubocop/rubocop#7468
sue445
added a commit
to sue445/rubicure_api
that referenced
this pull request
Nov 27, 2019
…renamed since rubocop 0.77.0 c.f. rubocop/rubocop#7468
app2641
added a commit
to grooves/forkwell_cop
that referenced
this pull request
Nov 28, 2019
app2641
added a commit
to grooves/forkwell_cop
that referenced
this pull request
Nov 28, 2019
This was referenced Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #7077, some further cop renaming to assist with the path to v1.0.
Affected cops in this tranche:
Layout/AlignArguments->Layout/ArgumentAlignmentLayout/AlignArray->Layout/ArrayAlignmentLayout/AlignHash->Layout/HashAlignmentLayout/AlignParameters->Layout/ParameterAlignmentLayout/IndentAssignment->Layout/AssingmentIndentationLayout/IndentFirstArgument->Layout/FirstArgumentIndentationLayout/IndentFirstArrayElement->Layout/FirstArrayElementIndentationLayout/IndentFirstHashElement->Layout/FirstHashElementIndentationLayout/IndentFirstParameter->Layout/FirstParameterIndentationLayout/IndentHeredoc->Layout/HeredocIndentationLayout/LeadingBlankLines->Layout/LeadingEmptyLinesLayout/TrailingBlankLines->Layout/TrailingEmptyLinesLint/DuplicatedKey->Lint/DuplicateHashKeyLint/HandleExceptions->Lint/SuppressedExceptionLint/MultipleCompare->Lint/MultipleComparisonLint/StringConversionInInterpolation->RedundantStringCoercionNaming/UncommunicativeBlockParamName->Naming/BlockParameterNameNaming/UncommunicativeMethodParamName->Naming/MethodParameterNameIn addition:
disabledirectives forLint/HandleExceptions(nowLint/SuppressedException) are updated, with olderenable/disableblocks replaced with end-of-linedisablestatementsconfig_obsoletion.rband its associated RSpec file have been reordered alphabetically to make future additions and amendments easier.