Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rubocop config file to follow 0.82 #5

Merged
merged 6 commits into from Jul 16, 2020
Merged

Update Rubocop config file to follow 0.82 #5

merged 6 commits into from Jul 16, 2020

Conversation

garaujodev
Copy link
Contributor

  • Add rubocop-rails require (standalone gem now) - Ref
  • Rename Layout/AlignParameters to Layout/ParameterAlignment - Ref
  • Rename Layout/IndentHash to Layout/FirstHashElementIndentation - Ref & Ref
  • Rename Layout/AlignHash to Layout/HashAlignment - Ref
  • Remove Style/BracesAroundHashParameters deprecated cop - Ref
  • Rename Metrics/LineLength to Layout/LineLength - Ref

wevtimoteo
wevtimoteo approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@wevtimoteo wevtimoteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Can you cherry-pick these changes to latest branch in another PR?

@wevtimoteo wevtimoteo merged commit cb46571 into master Jul 16, 2020
@wevtimoteo wevtimoteo deleted the bump-rubocop-stable-tag-to-0-82 branch July 16, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wevtimoteo wevtimoteo wevtimoteo approved these changes

@beatrizChagas beatrizChagas beatrizChagas approved these changes

Assignees

@garaujodev garaujodev

Labels
engine-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garaujodev @wevtimoteo @beatrizChagas