Update to rubocop 0.76 #163

zachsabin · 2019-11-09T00:29:14Z

This will drop support for ruby 2.2 and add it for ruby 2.6. It's probably best reviewed commit by commit as I tried to bundle changes logically -- many cops switched files and that will be more clear if you look solely at commits.

I looked through the changelogs for rubocop up to 0.76.0 and the changelogs for rubocop-performance and rubocop-rails.

zachsabin · 2019-11-09T00:29:57Z

rubocop-airbnb/config/rubocop-layout.yml

@@ -474,11 +472,6 @@ Layout/SpaceInsideBlockBraces:
  EnforcedStyleForEmptyBraces: no_space
  SpaceBeforeBlockParameters: true

-Layout/SpaceInsideParens:


This was just duplicated elsewhere in the file! It still exists, but the newer rubocop doesn't allow duplicated styles it seems.

zachsabin · 2019-11-09T00:31:12Z

rubocop-airbnb/config/rubocop-layout.yml

@@ -344,7 +343,6 @@ Layout/MultilineMethodCallIndentation:
  SupportedStyles:
  - aligned
  - indented
-  IndentationWidth:


IndentationWidth isn't supported anymore, although I can't find in the rubocop changelog where exactly that happened.

The name of the cop is Layout/IndentationWidth. This line with bare IndentationWidth should probably never have been here, so you were right to remove it.

zachsabin · 2019-11-09T00:33:04Z

rubocop-airbnb/config/rubocop-style.yml

-  SupportedStyles:
-  - when_needed
-  - always
+  EnforcedStyle: always


when_needed does not appear to be allowed anymore.

Error: invalid EnforcedStyle 'when_needed' for Style/FrozenStringLiteralComment found in config/rubocop-style.yml Valid choices are: always, never

zachsabin · 2019-11-09T00:33:28Z

rubocop-airbnb/config/rubocop-style.yml

@@ -328,11 +328,6 @@ Style/ExpandPathArguments:
  Description: "Use `expand_path(__dir__)` instead of `expand_path('..', __FILE__)`."
  Enabled: false

-Style/FlipFlop:


Moved to rubocop-airbnb/config/rubocop-lint.yml

… in RuboCop::Cop::Rails::ReflectionClassName

zachsabin · 2019-11-09T00:54:51Z

rubocop-airbnb/config/rubocop-gemspec.yml

@@ -7,3 +7,6 @@ Gemspec/RequiredRubyVersion:
  Enabled: false
  Include:
    - '**/*.gemspec'
+
+Gemspec/RubyVersionGlobalsUsage:


This is enabled by default -- is it worth explicitly enabling here or should we just use the rubocop default settings?

Let's explicitly enable it here for clarity. I don't know where the Rubocop defaults are set but I see tons of enabled cops in our configs that are probably also enabled by default.

BMorearty · 2019-11-13T05:12:55Z

rubocop-airbnb/config/rubocop-layout.yml

@@ -344,7 +343,6 @@ Layout/MultilineMethodCallIndentation:
  SupportedStyles:
  - aligned
  - indented
-  IndentationWidth:


The name of the cop is Layout/IndentationWidth. This line with bare IndentationWidth should probably never have been here, so you were right to remove it.

BMorearty · 2019-11-13T05:13:57Z

rubocop-airbnb/config/rubocop-style.yml

-  EnforcedStyle: when_needed
-  SupportedStyles:
-  - when_needed
-  - always


Should this stay here, but with - never and - always as the choices?

BMorearty · 2019-11-13T05:32:51Z

rubocop-airbnb/config/rubocop-airbnb.yml

@@ -2,11 +2,6 @@
 # They are custom built for use inside Airbnb and address issues that we have experienced in
 # testing and production.

-Airbnb/ClassName:


We can probably delete class_name.rb and class_name_spec.rb now that we're using Rubocop's ReflectionClassName cop instead.

BMorearty · 2019-11-13T05:37:33Z

rubocop-airbnb/config/rubocop-layout.yml

@@ -551,3 +551,6 @@ Layout/TrailingWhitespace:
  Description: Avoid trailing whitespace.
  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-trailing-whitespace
  Enabled: true
+
+Layout/IndentFirstParameter:


It looks like the documented name is Layout/FirstParameterIndentation. Let's use that name instead of the alias to make it easier to find documentation.

https://github.com/rubocop-hq/rubocop/blob/a29694f7821ef51ca58528ca703bce9ec713716b/lib/rubocop/config_obsoletion.rb#L17

BMorearty · 2019-11-13T05:45:03Z

rubocop-airbnb/config/rubocop-gemspec.yml

@@ -7,3 +7,6 @@ Gemspec/RequiredRubyVersion:
  Enabled: false
  Include:
    - '**/*.gemspec'
+
+Gemspec/RubyVersionGlobalsUsage:


Let's explicitly enable it here for clarity. I don't know where the Rubocop defaults are set but I see tons of enabled cops in our configs that are probably also enabled by default.

BMorearty · 2019-11-13T05:49:19Z

rubocop-airbnb/config/rubocop-layout.yml

@@ -227,7 +227,7 @@ Layout/FirstMethodParameterLineBreak:
  Enabled: false

 # Supports --auto-correct
-Layout/FirstParameterIndentation:
+Layout/IndentFirstArgument:


The new name is Layout/FirstArgumentIndentation.

BMorearty · 2019-11-13T05:49:44Z

rubocop-airbnb/config/rubocop-layout.yml

@@ -238,7 +238,7 @@ Layout/FirstParameterIndentation:
  - special_for_inner_method_call_in_parentheses

 # Supports --auto-correct
-Layout/IndentArray:
+Layout/IndentFirstArrayElement:


The new name is Layout/FirstArrayElementIndentation.

BMorearty · 2019-11-13T05:50:03Z

rubocop-airbnb/config/rubocop-layout.yml


 # Supports --auto-correct
-Layout/IndentHash:
+Layout/IndentFirstHashElement:


The new name is Layout/FirstHashElementIndentation

I think all of these Indent -> Indentation name changes are in rubocop 0.77, which isn't released yet.

rubocop/rubocop#7468

BMorearty · 2019-11-13T05:51:22Z

This is great. I would also like to see this change:

Disable Layout/EmptyLineAfterGuardClause (new cop in 0.58.3).

BMorearty

Looks like Layout/EmptyLineAfterGuardClause was already disabled and the class_name.rb cop was already removed.

LGTM!

zachary_sabin added 9 commits November 8, 2019 16:15

bump gem versions, add new gems that have been spun out

cacb774

require new gems in config file

72066c1

fix ruby compilation

9d2dd27

migrate cop names

72bfac7

remove duplicate rule

784a4c8

move flip flop to correct file

1421a32

transfer cops from performance.yml to style.yml

2bfe2db

don't freeze since file has frozen string comment

b0a5edf

remove 2.2 from CI, add 2.6

4a190d2

zachsabin commented Nov 9, 2019

View reviewed changes

zachary_sabin added 5 commits November 8, 2019 16:37

add Rails/IgnoredSkipActionFilterOption cop

7a94864

Remove Airbnb/ClassName cop, since that functionality is now included…

5493a81

… in RuboCop::Cop::Rails::ReflectionClassName

Disable Naming/RescuedExceptionsVariableName

81df175

add Layout/IndentFirstParameter cop

cb67d63

explicitly enable Gemspec/RubyVersionGlobalsUsage

cb8d599

zachsabin commented Nov 9, 2019

View reviewed changes

BMorearty reviewed Nov 13, 2019

View reviewed changes

show supported styles

c04fccf

BMorearty approved these changes Nov 13, 2019

View reviewed changes

zachary_sabin added 3 commits November 13, 2019 09:55

bump version

944aac1

update changelog and readme

4591307

add comma to readme

39f16ea

zachsabin merged commit dcbc6dc into airbnb:master Nov 13, 2019

tomprats mentioned this pull request Nov 15, 2019

Update to rubocop-airbnb traitify/rubocop-traitify#1

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to rubocop 0.76 #163

Update to rubocop 0.76 #163

zachsabin commented Nov 9, 2019 •

edited

zachsabin Nov 9, 2019

zachsabin Nov 9, 2019

BMorearty Nov 13, 2019

zachsabin Nov 9, 2019

zachsabin Nov 9, 2019

zachsabin Nov 9, 2019

BMorearty Nov 13, 2019

BMorearty Nov 13, 2019

BMorearty Nov 13, 2019

BMorearty Nov 13, 2019

BMorearty Nov 13, 2019

BMorearty Nov 13, 2019

BMorearty Nov 13, 2019

BMorearty Nov 13, 2019

BMorearty Nov 13, 2019

zachsabin Nov 13, 2019 •

edited

BMorearty commented Nov 13, 2019

BMorearty left a comment

Update to rubocop 0.76 #163

Update to rubocop 0.76 #163

Conversation

zachsabin commented Nov 9, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zachsabin Nov 13, 2019 • edited

Choose a reason for hiding this comment

BMorearty commented Nov 13, 2019

BMorearty left a comment

Choose a reason for hiding this comment

zachsabin commented Nov 9, 2019 •

edited

zachsabin Nov 13, 2019 •

edited