Drop Ruby 2.5 support #10577

koic · 2022-04-24T10:54:13Z

This includes the following changes:

Require JRuby 9.3 or higher

CRuby 2.5 compatible JRuby 9.2 will be dropped and CRuby 2.6 compatible JRuby 9.3 or higher is required.

Retire `Lint/UselessElse` cop

Ruby 2.6 does not support begin ... else syntax. So Lint/UselessElse can't work because it causes a parsing error.

NOTE: Some bugs found in RuboCop 1.28.1 have been fixed in the master branch. If the next version is a bug fix (i.e. 1.28.2), this PR would wait to be merged until the next minor release.

Before submitting the PR make sure the following are checked:

The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
Wrote good commit messages.
Commit message starts with [Fix #issue-number] (if the related issue exists).
Feature branch is up-to-date with master (if not - rebase it).
Squashed related commits together.
Added tests.
Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This includes the following changes: This PR drops Ruby 2.5 support. And CRuby 2.5 compatible JRuby 9.2 will be dropped and CRuby 2.6 compatible JRuby 9.3 or higher is required.

Ruby 2.6 does not support `begin` ... `else` syntax. So `Lint/UselessElse` can't work because it causes a parsing error.

bbatsov · 2022-04-25T06:58:23Z

Excellent PR! It shows you the nice progress that every Ruby release has made, given the many small improvements that are now possible in RuboCop's code. 🚀

I was wondering for a bit i we shouldn't make Lint/UselessElse a no-op to reduce the likelihood of something breaking after this update, but I doubt anyone was disabling it, so the deletion should likely be fine.

bbatsov · 2022-04-25T06:58:39Z

(and I did cut 1.28.2 just before merging this PR)

Follow up rubocop/rubocop#10577.

Reference: rubocop/rubocop#10577

Follow up: rubocop/rubocop#10577

Follow up rubocop/rubocop#10577.

Follow up: rubocop/rubocop#10577

- rubocop/rubocop#10577 Signed-off-by: Peter Boling <peter.boling@gmail.com>

…2.5` Fixes rubocop#10625 and reverts part of rubocop#10577. Only the Ruby version (2.5) to runtime should have been dropped, not code analysis. This PR the specification to `TargetRubyVersion: 2.5` So, this keeps it compatible with `TargetRubyVersion` up to 1.28.2.

Fixes #10625 and reverts part of #10577. Only the Ruby version (2.5) to runtime should have been dropped, not code analysis. This PR the specification to `TargetRubyVersion: 2.5` So, this keeps it compatible with `TargetRubyVersion` up to 1.28.2.

deivid-rodriguez · 2022-06-06T19:07:45Z

Hi @koic, thanks for all the work here. Should the Lint/UselessElseWithoutRescue should also be restored, given that TargetRubyVersion: 2.5 is back?

This reverts commit 6d0b336 and tweaked. Follow up rubocop#10577 (comment). RuboCop 1.29.1 and higher can analyze Ruby 2.5 code again, so it can restore the cop.

koic · 2022-06-07T04:07:42Z

@deivid-rodriguez Yup, I think so too! I've opened #10697 to restore the Lint/UselessElseWithoutRescue cop. Thank you!

This reverts commit 6d0b336 and tweaked. Follow up #10577 (comment). RuboCop 1.29.1 and higher can analyze Ruby 2.5 code again, so it can restore the cop.

Follow rubocop/rubocop#10577. This PR drops Ruby 2.5 runtime support and fixes the following build error. https://github.com/utkarsh2102/rubocop-packaging/runs/7688082957

Follow up rubocop/rubocop#10577. This commit drops Ruby 2.5 runtime support. And CRuby 2.5 compatible JRuby 9.2 will be dropped and CRuby 2.6 compatible JRuby 9.3 or higher is required.

Follow up rubocop/rubocop#10577.

Follow up: rubocop/rubocop#10577

Follow up rubocop/rubocop#10577.

Follow up: rubocop/rubocop#10577

koic added 2 commits April 24, 2022 19:41

Drop Ruby 2.5 support

e5b53f6

This includes the following changes: This PR drops Ruby 2.5 support. And CRuby 2.5 compatible JRuby 9.2 will be dropped and CRuby 2.6 compatible JRuby 9.3 or higher is required.

Retire Lint/UselessElseWithoutRescue cop

6d0b336

Ruby 2.6 does not support `begin` ... `else` syntax. So `Lint/UselessElse` can't work because it causes a parsing error.

bbatsov merged commit 2155629 into rubocop:master Apr 25, 2022

koic deleted the drop_ruby_25 branch April 25, 2022 07:20

koic added a commit to koic/rubocop-rails that referenced this pull request Apr 25, 2022

Drop Ruby 2.5 support

68423f7

Follow up rubocop/rubocop#10577.

koic mentioned this pull request Apr 25, 2022

Drop Ruby 2.5 support rubocop/rubocop-rails#697

Merged

10 tasks

koic added a commit to koic/rubocop-performance that referenced this pull request Apr 25, 2022

Drop Ruby 2.5 support

a1cfc94

Follow up rubocop/rubocop#10577.

koic mentioned this pull request Apr 25, 2022

Drop Ruby 2.5 support rubocop/rubocop-performance#287

Merged

8 tasks

koic added a commit to koic/rubocop-minitest that referenced this pull request Apr 25, 2022

Drop Ruby 2.5 support

b07125d

Follow up rubocop/rubocop#10577.

koic mentioned this pull request Apr 25, 2022

Drop Ruby 2.5 support rubocop/rubocop-minitest#168

Merged

8 tasks

ydah added a commit to ydah/rubocop-rspec that referenced this pull request Apr 26, 2022

Drop Ruby 2.5 support

e032dcc

Reference: rubocop/rubocop#10577

ydah mentioned this pull request Apr 26, 2022

Drop Ruby 2.5 support rubocop/rubocop-rspec#1267

Merged

4 tasks

ydah added a commit to ydah/rubocop-rspec that referenced this pull request Apr 26, 2022

Drop Ruby 2.5 support

6c235c2

Follow up: rubocop/rubocop#10577

ydah added a commit to ydah/rubocop-rspec that referenced this pull request Apr 26, 2022

Drop Ruby 2.5 support

b21a880

Follow up: rubocop/rubocop#10577

koic added a commit to koic/rubocop-ast that referenced this pull request Apr 26, 2022

Drop Ruby 2.5 support

41b549b

Follow up rubocop/rubocop#10577.

koic mentioned this pull request Apr 26, 2022

Drop Ruby 2.5 support rubocop/rubocop-ast#232

Merged

marcandre pushed a commit to rubocop/rubocop-ast that referenced this pull request Apr 26, 2022

Drop Ruby 2.5 support

5b53037

Follow up rubocop/rubocop#10577.

ydah added a commit to ydah/rubocop-rspec that referenced this pull request Apr 27, 2022

Drop Ruby 2.5 support

6b99116

Follow up: rubocop/rubocop#10577

pboling added a commit to rubocop-lts/rubocop-ruby2_5 that referenced this pull request May 2, 2022

📌 Pin rubocop to 1.28.2; next version will drop ruby 2.5

27ced79

- rubocop/rubocop#10577 Signed-off-by: Peter Boling <peter.boling@gmail.com>

bwatson78 mentioned this pull request May 9, 2022

Removal of Rubocop Cop that is stopping the build process. samvera/bixby#71

Closed

koic mentioned this pull request May 12, 2022

[Fix #10625] Restore the specification to TargetRubyVersion: 2.5 #10626

Merged

8 tasks

iriscoopers mentioned this pull request May 31, 2022

Remove retired UselessElseWithoutRescue cop Springest/rubocop-springest#2

Closed

koic mentioned this pull request Jun 7, 2022

Restore Lint/UselessElseWithoutRescue cop #10697

Merged

8 tasks

bbatsov pushed a commit that referenced this pull request Jun 7, 2022

Restore Lint/UselessElseWithoutRescue cop

c258452

This reverts commit 6d0b336 and tweaked. Follow up #10577 (comment). RuboCop 1.29.1 and higher can analyze Ruby 2.5 code again, so it can restore the cop.

pirj mentioned this pull request Jun 19, 2022

Restore docs for Lint/UselessElseWithoutRescue #10724

Closed

5 tasks

pirj mentioned this pull request Jul 11, 2022

Follow-up clean-up of Ruby < 2.6 #10805

Closed

5 tasks

koic mentioned this pull request Aug 5, 2022

Drop Ruby 2.5 runtime support utkarsh2102/rubocop-packaging#46

Merged

renawatson68 added a commit to renawatson68/performance-develop-rubyonrails that referenced this pull request Sep 23, 2022

Drop Ruby 2.5 support

fdd17c3

Follow up rubocop/rubocop#10577.

richardstewart0213 added a commit to richardstewart0213/performance-build-Performance-optimization-analysis- that referenced this pull request Nov 4, 2022

Drop Ruby 2.5 support

847e675

Follow up rubocop/rubocop#10577.

pirj pushed a commit to rubocop/rubocop-capybara that referenced this pull request Dec 29, 2022

Drop Ruby 2.5 support

0bfc353

Follow up: rubocop/rubocop#10577

ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Apr 13, 2023

Drop Ruby 2.5 support

92f7aff

Follow up: rubocop/rubocop#10577

MarttiCheng added a commit to MarttiCheng/Rubocop-Performance that referenced this pull request Sep 28, 2023

Drop Ruby 2.5 support

a8c416a

Follow up rubocop/rubocop#10577.

SerhiiMisiura added a commit to SerhiiMisiura/Rubocop-Performance that referenced this pull request Oct 5, 2023

Drop Ruby 2.5 support

556d877

Follow up rubocop/rubocop#10577.

ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Mar 27, 2024

Drop Ruby 2.5 support

7c341f6

Follow up: rubocop/rubocop#10577

ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Mar 27, 2024

Drop Ruby 2.5 support

d53735a

Follow up: rubocop/rubocop#10577

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop Ruby 2.5 support #10577

Drop Ruby 2.5 support #10577

koic commented Apr 24, 2022

bbatsov commented Apr 25, 2022

bbatsov commented Apr 25, 2022

deivid-rodriguez commented Jun 6, 2022

koic commented Jun 7, 2022

Drop Ruby 2.5 support #10577

Drop Ruby 2.5 support #10577

Conversation

koic commented Apr 24, 2022

Require JRuby 9.3 or higher

Retire Lint/UselessElse cop

bbatsov commented Apr 25, 2022

bbatsov commented Apr 25, 2022

deivid-rodriguez commented Jun 6, 2022

koic commented Jun 7, 2022

Retire `Lint/UselessElse` cop