[Fix #10625] Restore the specification to TargetRubyVersion: 2.5
#10626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2.5` Fixes rubocop#10625 and reverts part of rubocop#10577. Only the Ruby version (2.5) to runtime should have been dropped, not code analysis. This PR the specification to `TargetRubyVersion: 2.5` So, this keeps it compatible with `TargetRubyVersion` up to 1.28.2.
|
Thanks! |
|
Thanks @koic! |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 13, 2022
This PR fixes default Ruby version from 2.5 to 2.6. In rubocop#10626 (RuboCop 1.29.1) , the default target Ruby version is 2.5. This is an unexpected regression behavior and the default target Ruby version is expected to be 2.6.
bbatsov
pushed a commit
that referenced
this pull request
May 13, 2022
This PR fixes default Ruby version from 2.5 to 2.6. In #10626 (RuboCop 1.29.1) , the default target Ruby version is 2.5. This is an unexpected regression behavior and the default target Ruby version is expected to be 2.6.
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 13, 2022
…ersion: 2.4` Fixes rubocop#10258 and reverts part of rubocop#9648. Only the Ruby version (2.4) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.4 code analysis with `TargetRubyVersion: 2.4`. So, this keeps it compatible with `TargetRubyVersion` up to RuboCop 1.12.1 as semver. It aims to solve essentially the same problem as rubocop#10626.
bbatsov
pushed a commit
that referenced
this pull request
May 13, 2022
… 2.4` Fixes #10258 and reverts part of #9648. Only the Ruby version (2.4) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.4 code analysis with `TargetRubyVersion: 2.4`. So, this keeps it compatible with `TargetRubyVersion` up to RuboCop 1.12.1 as semver. It aims to solve essentially the same problem as #10626.
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
May 13, 2022
RuboCop can analyze Ruby 1.9 or later. But now it turns out that RuboCop hasn't been able to parse older Ruby versions. https://docs.rubocop.org/rubocop/1.29/compatibility.html#support-matrix Analysis Ruby code and runtime Ruby versions are different. So, only runtime version should have been dropped. This PR makes it possible to parse older Ruby versions that were accidentally dropped before RuboCop AST was separated from RuboCop core. With this fix, the following recovery work will be possible. - Recover for Ruby 2.5 analysis: rubocop/rubocop#10626 - Recover for Ruby 2.4 analysis: rubocop/rubocop#10632
marcandre
pushed a commit
to rubocop/rubocop-ast
that referenced
this pull request
May 13, 2022
RuboCop can analyze Ruby 1.9 or later. But now it turns out that RuboCop hasn't been able to parse older Ruby versions. https://docs.rubocop.org/rubocop/1.29/compatibility.html#support-matrix Analysis Ruby code and runtime Ruby versions are different. So, only runtime version should have been dropped. This PR makes it possible to parse older Ruby versions that were accidentally dropped before RuboCop AST was separated from RuboCop core. With this fix, the following recovery work will be possible. - Recover for Ruby 2.5 analysis: rubocop/rubocop#10626 - Recover for Ruby 2.4 analysis: rubocop/rubocop#10632
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
May 15, 2022
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 16, 2022
Follow up rubocop#10632 (comment). Reverts part of rubocop#7869 and rubocop#8056. Only the Ruby version (2.3) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.3 code analysis with `TargetRubyVersion: 2.3`. It aims to solve essentially the same problem as rubocop#10626 and 10632. And this change requires RuboCop AST 1.18 or later: rubocop/rubocop-ast#233
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 18, 2022
Follow up rubocop#10632 (comment). Reverts part of rubocop#6766, rubocop#7026, and rubocop#7030. Only the Ruby version (2.2) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.2 code analysis with `TargetRubyVersion: 2.2`. It aims to solve essentially the same problem as rubocop#10626, rubocop#10632, and rubocop#10640. Previously, there was the following default enforced style `when_needed` for `Style/FrozenStringLiteralComment` cop. ```ruby # @example EnforcedStyle: when_needed (default) # # The `when_needed` style will add the frozen string literal # # to files only when the `TargetRubyVersion` is set to 2.3+. # # bad # module Foo # # ... # end # # # good # # frozen_string_literal: true # # module Foo # # ... # end ``` This PR does not restore that option, but sets the `minimum_target_ruby_version 2.3` to make `always (default)` apply by default. It is a simple solution that does not handle frozen literal magic comment added in Ruby 2.3 when `TargetRubyVersion` is Ruby 2.2 or lower.
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 23, 2022
Follow up rubocop#10632 (comment). Reverts part of rubocop#5990 and rubocop#6101. Only the Ruby version (2.1) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.1 code analysis with `TargetRubyVersion: 2.1`. It aims to solve essentially the same problem as rubocop#10626, rubocop#10632, rubocop#10640, and rubocop#10644.
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 25, 2022
Follow up rubocop#10632 (comment). Reverts part of rubocop#4787. Only the Ruby version (2.0) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.0 code analysis with `TargetRubyVersion: 2.0`. It aims to solve essentially the same problem as rubocop#10626, rubocop#10632, rubocop#10640, rubocop#10644, and rubocop#10662.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10625 and reverts part of #10577.
Only the Ruby version (2.5) to runtime should have been dropped, not code analysis.
This PR the specification to
TargetRubyVersion: 2.5So, this keeps it compatible withTargetRubyVersionup to 1.28.2.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.