Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore docs for Lint/UselessElseWithoutRescue #10724

Conversation

pirj
Copy link
Member

@pirj pirj commented Jun 19, 2022

When running rake update_cops_documentation, this cop's docs keep being added.

The cop was removed in #10577, and after a fix for Ruby code parsing in RuboCop 1.29.1, was restored in #10697
But the docs were left out.

Please pardon my ignorance if the missing docs are filled in during the new version release process. I'm scratching my itch of getting rid of unrelated changes when I run rake update_cops_documentation when developing on a branch branched off of master.
Please don't hesitate to close this PR, as I can definitely live with git checkout --patch, and this is a temporary hiccup.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • [-] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

| Yes
| No
| 0.17
| <<next>>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR restoring this cop was one day late for 1.30.1.

@koic
Copy link
Member

koic commented Jun 19, 2022

I’ll close this PR. Please see #10718 for details. Thank you.

@koic koic closed this Jun 19, 2022
@pirj pirj deleted the add-missing-docs-for-useless-else-without-rescue branch June 19, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants