Change the max line length of Layout/LineLength to 120
#7952
+204
−417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the max line length of `Layout/LineLength` from 80 to 120 based on rubocop#7833 survey.
|
Thanks! |
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
May 12, 2020
koic
added a commit
to rubocop/rubocop-performance
that referenced
this pull request
May 12, 2020
|
Have the survey results been published? |
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
May 21, 2020
mattbrictson
added a commit
to mattbrictson/dotfiles
that referenced
this pull request
May 23, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo-plugin-sidekiq
that referenced
this pull request
May 23, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo-plugin-sidekiq
that referenced
this pull request
May 23, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo-plugin-rollbar
that referenced
this pull request
May 23, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo-plugin-rollbar
that referenced
this pull request
May 23, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo-plugin-nvm
that referenced
this pull request
May 23, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo-plugin-nvm
that referenced
this pull request
May 23, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo
that referenced
this pull request
May 24, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/gem
that referenced
this pull request
May 24, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo-plugin
that referenced
this pull request
May 24, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/gem
that referenced
this pull request
May 24, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo
that referenced
this pull request
May 24, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
mattbrictson
added a commit
to mattbrictson/tomo-plugin
that referenced
this pull request
May 24, 2020
The rubocop community has decided to standardize on 120 characters for default line length. rubocop/rubocop#7952 Update rubocop config and reformat ruby files to embrace this convention.
louim
added a commit
to hooktstudios/rubocop-hookt
that referenced
this pull request
May 25, 2020
The official setting was recently bumped to 120 chars in rubocop/rubocop#7952 We had it bumped from 80 to 100, but it doesn't make sense anymore to have it smaller than the default.
koic
added a commit
to rubocop/rubocop-minitest
that referenced
this pull request
May 31, 2020
https://metaredux.com/posts/2020/05/26/rubocop-defaults-survey-results.html |
|
@koic I guess, you forgot about description: https://github.com/koic/rubocop/blob/9408f1fed81a5a7d2ed68e7f70f726d6c6a1be45/config/default.yml#L860-L861 UPD: I see it fixed in |
|
Yeah, I updated this a few days later. |
mockdeep
pushed a commit
to mockdeep/rubocop-rspec
that referenced
this pull request
Jun 14, 2020
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jul 15, 2020
Follow up rubocop#7952. This PR sets default max line length to 120 for `Style/MultilineMethodSignature`. A forgotten change have been found as well as: https://github.com/rubocop-hq/rubocop/pull/8203/files#diff-533235edf6b414408f1b9f380c00af0d
bbatsov
pushed a commit
that referenced
this pull request
Jul 15, 2020
Follow up #7952. This PR sets default max line length to 120 for `Style/MultilineMethodSignature`. A forgotten change have been found as well as: https://github.com/rubocop-hq/rubocop/pull/8203/files#diff-533235edf6b414408f1b9f380c00af0d
johnboyes
added a commit
to johnboyes/hotcustard-payments
that referenced
this pull request
Aug 22, 2020
[RuboCop changed the default from 80 chars to 120][1] in May 2020. [1]: rubocop/rubocop#7952
johnboyes
added a commit
to johnboyes/hotcustard-payments
that referenced
this pull request
Aug 22, 2020
* Fix problem with RuboCop checks We were using Hound for our RuboCop checks, but it wasn't working properly for some reason. Switching to [Reviewdog's GitHub Action][1]. [1]: https://github.com/reviewdog/action-rubocop * Rename Reviewdog GitHub Actions The previous naming format led to our Reviewdog actions appearing with an incorrect name in the GitHub Actions UI. * Use the RuboCop default line length of 120 chars [RuboCop changed the default from 80 chars to 120][1] in May 2020. [1]: rubocop/rubocop#7952 * Add an empty line after guard clauses As prompted by RuboCop. * Rename variable as prompted by RuboCop * Rename variable as prompted by RuboCop * Remove unused block argument as per RuboCop * Move private declaration to outside method As per RuboCop * Remove obsolete RuboCop exclusion * Enable all new RuboCop cops The more RuboCop checks, the better :-) * Fix new RuboCop errors
renawatson68
added a commit
to renawatson68/performance-develop-rubyonrails
that referenced
this pull request
Sep 23, 2022
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
pirj
added a commit
to rubocop/rubocop-capybara
that referenced
this pull request
Dec 29, 2022
ydah
pushed a commit
to rubocop/rubocop-factory_bot
that referenced
this pull request
Apr 13, 2023
MarttiCheng
added a commit
to MarttiCheng/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the max line length of
Layout/LineLengthfrom 80 to 120 based on #7833 survey.Cc @rubocop-hq/rubocop-core
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.