Restore rubocop line length to the official setting #5
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official setting was recently bumped to 120 chars in rubocop/rubocop#7952 We had it bumped from 80 to 100, but it doesn't make sense anymore to have it smaller than the default.
goduchesne
approved these changes
May 25, 2020
|
Ah ouin à cause ça va dire genre inline tel if ou tel unless qui rentre maintenant sur une ligne. 120 is the new 100 I guess! Plus d'écran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official setting was recently bumped to 120 chars in rubocop/rubocop#7952
We had it bumped from 80 to 100, but it doesn't make sense anymore to have it smaller than the default.
This will probably require a batch of fixes in each repos, but I'm pretty sure they are all autocorrect, and I'm all for a larger line length.