Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default max line length to 120 for Style/MultilineMethodSignature #8350

Conversation

koic
Copy link
Member

@koic koic commented Jul 15, 2020

Follow up #7952.

This PR sets default max line length to 120 for Style/MultilineMethodSignature.

A forgotten change have been found as well as:
https://github.com/rubocop-hq/rubocop/pull/8203/files#diff-533235edf6b414408f1b9f380c00af0d


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow up rubocop#7952.

This PR sets default max line length to 120 for `Style/MultilineMethodSignature`.

A forgotten change have been found as well as:
https://github.com/rubocop-hq/rubocop/pull/8203/files#diff-533235edf6b414408f1b9f380c00af0d
@koic koic force-pushed the set_default_line_length_120_for_multiline_method_signature branch from 52f4517 to e5780bc Compare July 15, 2020 19:31
@bbatsov bbatsov merged commit 2683d15 into rubocop:master Jul 15, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jul 15, 2020

Thanks!

@koic koic deleted the set_default_line_length_120_for_multiline_method_signature branch July 15, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants