Handle lockfiles in subdirectories #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
reviewed
Jul 21, 2021
| repo | ||
| ) | ||
| end | ||
| GitCommandRunner.clone_repository("https://github.com/#{repo}", repo) unless Dir.exist?(repo) |
There was a problem hiding this comment.
TIL: the Rubocop default line length has been upped to 120.
rubocop/rubocop#7952
| end | ||
| end | ||
| end | ||
| end | ||
|
|
||
| def self.run_unwapper_in_pwd(base_branch:, lock_files:) | ||
| def self.run_unwrappr_in_pwd(base_branch:, lock_files:, recursive:) | ||
| return unless any_lockfile_present?(lock_files) |
There was a problem hiding this comment.
I notice this check for lock-files. Does this mean the recursion won't run unless there's a lock file in the root of the git repository?
There was a problem hiding this comment.
Good spot. It does. I think that's OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some of our projects have separate bundles for deployment under
./deploy.Change
This PR updates the runner to add a recursive flag, which when specified will attempt to perform a
bundle updatein any subdirectory containing a lockfile and annotate this change.