Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow : in file names. #3972

Merged
merged 2 commits into from Feb 26, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utils/sanitizeFileName.ts
@@ -1,3 +1,8 @@
export function sanitizeFileName(name: string): string {
return name.replace(/[\0?*]/g, '_');
const match = /^[a-z]:/i.exec(name);
const driveLetter = match ? match[0] : "";

// A `:` is only allowed as part of a windows drive letter (ex: C:\foo)
// Otherwise, avoid them because they can refer to NTFS alternate data streams.
return driveLetter + name.substr(driveLetter.length).replace(/[\0?*:]/g, '_');
}
2 changes: 1 addition & 1 deletion test/chunking-form/samples/sanitize-chunk-names/_config.js
Expand Up @@ -5,7 +5,7 @@ module.exports = {
plugins: [
{
options(options) {
options.input = ['\0virtual-entry-1', '\0virtual-entry-2'];
options.input = ['\0virtual:entry-1', '\0virtual:entry-2'];
return options;
},
resolveId(id) {
Expand Down

This file was deleted.

This file was deleted.

@@ -0,0 +1,7 @@
define(function () { 'use strict';

var _virtual_entry1 = "\u0000virtual:entry-1";

return _virtual_entry1;

});
@@ -0,0 +1,7 @@
define(function () { 'use strict';

var _virtual_entry2 = "\u0000virtual:entry-2";

return _virtual_entry2;

});

This file was deleted.

This file was deleted.

@@ -0,0 +1,5 @@
'use strict';

var _virtual_entry1 = "\u0000virtual:entry-1";

module.exports = _virtual_entry1;
@@ -0,0 +1,5 @@
'use strict';

var _virtual_entry2 = "\u0000virtual:entry-2";

module.exports = _virtual_entry2;

This file was deleted.

This file was deleted.

@@ -0,0 +1,3 @@
var _virtual_entry1 = "\u0000virtual:entry-1";

export default _virtual_entry1;
@@ -0,0 +1,3 @@
var _virtual_entry2 = "\u0000virtual:entry-2";

export default _virtual_entry2;
Expand Up @@ -3,7 +3,7 @@ System.register([], function (exports) {
return {
execute: function () {

var _virtualEntry1 = exports('default', "\u0000virtual-entry-1");
var _virtual_entry1 = exports('default', "\u0000virtual:entry-1");

}
};
Expand Down
Expand Up @@ -3,7 +3,7 @@ System.register([], function (exports) {
return {
execute: function () {

var _virtualEntry2 = exports('default', "\u0000virtual-entry-2");
var _virtual_entry2 = exports('default', "\u0000virtual:entry-2");

}
};
Expand Down