New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow :
in file names.
#3972
Conversation
File paths with a colon in them can refer to an NTFS "alternate data stream" which does not operate like a normal file and can break many use cases. They should be avoided (except for the case of the Windows drive letter, like "C:"). This reverts some of the test changes made in 87586df which removed the `:` from the virtual entry names. This seems to be a convention in some plugins. The test now tests that those names don't result in invalid Windows file paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Codecov Report
@@ Coverage Diff @@
## master #3972 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 191 191
Lines 6706 6708 +2
Branches 1961 1962 +1
=======================================
+ Hits 6519 6521 +2
Misses 99 99
Partials 88 88
Continue to review full report at Codecov.
|
This reverts commit 85304f2.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
File paths with a colon in them can refer to an NTFS "alternate data
stream" which does not operate like a normal file and can break many use
cases. They should be avoided (except for the case of the Windows drive
letter, like "C:").
This reverts some of the test changes made in
87586df which removed the
:
fromthe virtual entry names. This seems to be a convention in some plugins.
The test now tests that those names don't result in invalid Windows file
paths.
I originally uncovered this in my own project, and it's blocking me from properly bundling Rollup'd code (via Snowpack) in my Windows build: NfNitLoop/feoblog#16