Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow : in file names. #3972

Merged
merged 2 commits into from Feb 26, 2021

Commits on Feb 23, 2021

  1. Don't allow : in file names.

    File paths with a colon in them can refer to an NTFS "alternate data
    stream" which does not operate like a normal file and can break many use
    cases. They should be avoided (except for the case of the Windows drive
    letter, like "C:").
    
    This reverts some of the test changes made in
    87586df which removed the `:` from
    the virtual entry names. This seems to be a convention in some plugins.
    The test now tests that those names don't result in invalid Windows file
    paths.
    NfNitLoop committed Feb 23, 2021
    Copy the full SHA
    7dc1aef View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Copy the full SHA
    d93d281 View commit details
    Browse the repository at this point in the history