New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix five different issues with this one PR #3320
Merged
heath-freenome
merged 1 commit into
rjsf-team:main
from
heath-freenome:fix-3317-3316-3315-3314-and-3302
Dec 28, 2022
Merged
fix: Fix five different issues with this one PR #3320
heath-freenome
merged 1 commit into
rjsf-team:main
from
heath-freenome:fix-3317-3316-3315-3314-and-3302
Dec 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: rjsf-team#3302, rjsf-team#3314, rjsf-team#3315, rjsf-team#3316 and rjsf-team#3317 - In `@rjsf/antd`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/bootstrap-4`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - Also, remove the one off tests for `AddButton` and `CheckboxWidget` since they are duplicated elsewhere - In `@rjsf/chakra-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/core`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also, passed `registry` into the `SubmitButton` inside of the `Form` as part of this fix - Updated `ArrayField` to pass the new `totalItems` prop to the `ArrayFieldItemTemplate` instances - Also refactored the near duplicate logic for `onAddClick` and `onAddIndexClick` into a new `_handleAddClick()` function - In `@rjsf/fluent-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/material-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/mui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/semantic-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also fixed the `CheckboxWidget` missing label issue - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/utils`, updated the `SubmitButtonProps` and `IconButtonProps` to add required `registry` prop - Updated the `ArrayFieldTemplateItemType` to add the new `totalItems` prop - Updated the `custom-templates.md` file to add documentation for the new props added to the types - Updated the `CHANGELOG.md` file accordingly
jacqueswho
approved these changes
Dec 28, 2022
8 tasks
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
fixes: rjsf-team#3302, rjsf-team#3314, rjsf-team#3315, rjsf-team#3316 and rjsf-team#3317 - In `@rjsf/antd`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/bootstrap-4`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - Also, remove the one off tests for `AddButton` and `CheckboxWidget` since they are duplicated elsewhere - In `@rjsf/chakra-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/core`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also, passed `registry` into the `SubmitButton` inside of the `Form` as part of this fix - Updated `ArrayField` to pass the new `totalItems` prop to the `ArrayFieldItemTemplate` instances - Also refactored the near duplicate logic for `onAddClick` and `onAddIndexClick` into a new `_handleAddClick()` function - In `@rjsf/fluent-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/material-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/mui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/semantic-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also fixed the `CheckboxWidget` missing label issue - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/utils`, updated the `SubmitButtonProps` and `IconButtonProps` to add required `registry` prop - Updated the `ArrayFieldTemplateItemType` to add the new `totalItems` prop - Updated the `custom-templates.md` file to add documentation for the new props added to the types - Updated the `CHANGELOG.md` file accordingly
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
fixes: rjsf-team#3302, rjsf-team#3314, rjsf-team#3315, rjsf-team#3316 and rjsf-team#3317 - In `@rjsf/antd`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/bootstrap-4`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - Also, remove the one off tests for `AddButton` and `CheckboxWidget` since they are duplicated elsewhere - In `@rjsf/chakra-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/core`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also, passed `registry` into the `SubmitButton` inside of the `Form` as part of this fix - Updated `ArrayField` to pass the new `totalItems` prop to the `ArrayFieldItemTemplate` instances - Also refactored the near duplicate logic for `onAddClick` and `onAddIndexClick` into a new `_handleAddClick()` function - In `@rjsf/fluent-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/material-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/mui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/semantic-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop - Also fixed the `CheckboxWidget` missing label issue - Also updated the `CheckboxWidget` tests to verify the label is passed correctly - In `@rjsf/utils`, updated the `SubmitButtonProps` and `IconButtonProps` to add required `registry` prop - Updated the `ArrayFieldTemplateItemType` to add the new `totalItems` prop - Updated the `custom-templates.md` file to add documentation for the new props added to the types - Updated the `CHANGELOG.md` file accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes: #3302 (borrowing the implementation from #3306), #3314, #3315, #3316 and #3317
@rjsf/antd
, pass the newregistry
prop into all of theButtonTemplates
usages, filtering it out when spreading props into the underlying button implementationCheckboxWidget
tests to verify the label is passed correctly@rjsf/bootstrap-4
, pass the newregistry
prop into all of theButtonTemplates
usages, filtering it out when spreading props into the underlying button implementationCheckboxWidget
to get therequired
state of the checkbox from theschemaRequiresTrueValue()
utility function rather than therequired
propCheckboxWidget
tests to verify the label is passed correctlyAddButton
andCheckboxWidget
since they are duplicated elsewhere@rjsf/chakra-ui
, pass the newregistry
prop into all of theButtonTemplates
usages, filtering it out when spreading props into the underlying button implementationCheckboxWidget
to get therequired
state of the checkbox from theschemaRequiresTrueValue()
utility function rather than therequired
propCheckboxWidget
tests to verify the label is passed correctly@rjsf/core
, pass the newregistry
prop into all of theButtonTemplates
usages, filtering it out when spreading props into the underlying button implementationregistry
into theSubmitButton
inside of theForm
as part of this fixArrayField
to pass the newtotalItems
prop to theArrayFieldItemTemplate
instancesonAddClick
andonAddIndexClick
into a new_handleAddClick()
function@rjsf/fluent-ui
, pass the newregistry
prop into all of theButtonTemplates
usages, filtering it out when spreading props into the underlying button implementationCheckboxWidget
tests to verify the label is passed correctly@rjsf/material-ui
, pass the newregistry
prop into all of theButtonTemplates
usages, filtering it out when spreading props into the underlying button implementationCheckboxWidget
tests to verify the label is passed correctly@rjsf/mui
, pass the newregistry
prop into all of theButtonTemplates
usages, filtering it out when spreading props into the underlying button implementationCheckboxWidget
tests to verify the label is passed correctly@rjsf/semantic-ui
, pass the newregistry
prop into all of theButtonTemplates
usages, filtering it out when spreading props into the underlying button implementationCheckboxWidget
to get therequired
state of the checkbox from theschemaRequiresTrueValue()
utility function rather than therequired
propCheckboxWidget
missing label issueCheckboxWidget
tests to verify the label is passed correctly@rjsf/utils
, updated theSubmitButtonProps
andIconButtonProps
to add requiredregistry
propArrayFieldTemplateItemType
to add the newtotalItems
propcustom-templates.md
file to add documentation for the new props added to the typesCHANGELOG.md
file accordinglyChecklist
npm run test:update
to update snapshots, if needed.