Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix five different issues with this one PR #3320

Merged

Commits on Dec 28, 2022

  1. fix: Fix five different issues with this one PR

    fixes: rjsf-team#3302, rjsf-team#3314, rjsf-team#3315, rjsf-team#3316 and rjsf-team#3317
    
    - In `@rjsf/antd`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation
      - Also updated the `CheckboxWidget` tests to verify the label is passed correctly
    - In `@rjsf/bootstrap-4`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation
      - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop
      - Also updated the `CheckboxWidget` tests to verify the label is passed correctly
      - Also, remove the one off tests for `AddButton` and `CheckboxWidget` since they are duplicated elsewhere
    - In `@rjsf/chakra-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation
      - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop
      - Also updated the `CheckboxWidget` tests to verify the label is passed correctly
    - In `@rjsf/core`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation
      - Also, passed `registry` into the `SubmitButton` inside of the `Form` as part of this fix
      - Updated `ArrayField` to pass the new `totalItems` prop to the `ArrayFieldItemTemplate` instances
        - Also refactored the near duplicate logic for `onAddClick` and `onAddIndexClick` into a new `_handleAddClick()` function
    - In `@rjsf/fluent-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation
      - Also updated the `CheckboxWidget` tests to verify the label is passed correctly
    - In `@rjsf/material-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation
      - Also updated the `CheckboxWidget` tests to verify the label is passed correctly
    - In `@rjsf/mui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation
      - Also updated the `CheckboxWidget` tests to verify the label is passed correctly
    - In `@rjsf/semantic-ui`, pass the new `registry` prop into all of the `ButtonTemplates` usages, filtering it out when spreading props into the underlying button implementation
      - Updated `CheckboxWidget` to get the `required` state of the checkbox from the `schemaRequiresTrueValue()` utility function rather than the `required` prop
      - Also fixed the `CheckboxWidget` missing label issue
      - Also updated the `CheckboxWidget` tests to verify the label is passed correctly
    - In `@rjsf/utils`, updated the `SubmitButtonProps` and `IconButtonProps` to add required `registry` prop
      - Updated the `ArrayFieldTemplateItemType` to add the new `totalItems` prop
    - Updated the `custom-templates.md` file to add documentation for the new props added to the types
    - Updated the `CHANGELOG.md` file accordingly
    heath-freenome committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    1921a4e View commit details
    Browse the repository at this point in the history