Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: label for checkbox widget #3306

Closed
wants to merge 9 commits into from
Closed

fix: label for checkbox widget #3306

wants to merge 9 commits into from

Conversation

jacqueswho
Copy link
Contributor

Reasons for making this change

fixes #3302

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@jacqueswho jacqueswho linked an issue Dec 21, 2022 that may be closed by this pull request
Boolean/Checkbox missing Title in Semantic-ui #3302
Closed
4 tasks
heath-freenome
heath-freenome requested changes Dec 21, 2022
View reviewed changes
packages/semantic-ui/package.json Outdated Show resolved Hide resolved
packages/semantic-ui/src/CheckboxWidget/CheckboxWidget.tsx Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@jacqueswho @heath-freenome
Update CHANGELOG.md
6ec5ff2 
Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
heath-freenome
heath-freenome reviewed Dec 21, 2022
View reviewed changes
package.json Show resolved Hide resolved
packages/bootstrap-4/package.json Outdated Show resolved Hide resolved
packages/chakra-ui/package.json Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/antd/package.json Outdated Show resolved Hide resolved
scripts/run.js Outdated Show resolved Hide resolved
packages/semantic-ui/package.json Outdated Show resolved Hide resolved
packages/mui/package.json Outdated Show resolved Hide resolved
packages/material-ui/package.json Outdated Show resolved Hide resolved
packages/fluent-ui/package.json Outdated Show resolved Hide resolved
@heath-freenome
Copy link
Member

heath-freenome commented Dec 21, 2022 •
edited

@jacqueswho can you please revert all of the lock file changes? This will probably fix the build

@jacqueswho jacqueswho force-pushed the 3302-booleancheckbox-missing-title-in-semantic-ui branch from 65c48f5 to 8b27ffc Compare December 22, 2022 06:16
@heath-freenome heath-freenome mentioned this pull request Dec 28, 2022
Merged
8 tasks
@heath-freenome
Copy link
Member

Closing as this code was reimplemented in #3320

@heath-freenome heath-freenome deleted the 3302-booleancheckbox-missing-title-in-semantic-ui branch December 29, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heath-freenome heath-freenome heath-freenome requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boolean/Checkbox missing Title in Semantic-ui
2 participants
@jacqueswho @heath-freenome