Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: label for checkbox widget #3306

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -16,6 +16,8 @@ should change the heading of the (upcoming) version to include a major version b

-->
# 5.0.0-beta-15
## @rjsf/semantic-ui
- Fix CheckboxWidget missing label [#3302](https://github.com/rjsf-team/react-jsonschema-form/issues/3302)
jacqueswho marked this conversation as resolved.
Show resolved Hide resolved

## @rjsf/core
- Pass the `schema` along to the `ArrayFieldItemTemplate` as part of the fix for [#3253](https://github.com/rjsf-team/react-jsonschema-form/issues/3253)
Expand Down
1 change: 0 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Expand Up @@ -18,7 +18,9 @@
"build-serial": "lerna run --concurrency 1 --stream build",
"start": "lerna run start --stream --parallel",
"pre-commit:husky": "lerna run --concurrency 1 --stream precommit",
"prepare": "husky install"
"prepare": "husky install",
"clean:modules": "rimraf node_modules && rimraf packages/*/node_modules",
"r": "node ./scripts/run.js"
jacqueswho marked this conversation as resolved.
Show resolved Hide resolved
},
"license": "Apache-2.0",
"homepage": "https://github.com/rjsf-team/react-jsonschema-form",
Expand Down
164 changes: 164 additions & 0 deletions packages/antd/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/antd/test/Form.test.tsx
Expand Up @@ -183,9 +183,10 @@ describe("single fields", () => {
.toJSON();
expect(tree).toMatchSnapshot();
});
test("checkbox field", () => {
test("checkbox field with label", () => {
const schema: RJSFSchema = {
type: "boolean",
title: "test",
};
const tree = renderer
.create(<Form schema={schema} validator={validator} />)
Expand Down
4 changes: 2 additions & 2 deletions packages/antd/test/__snapshots__/Form.test.tsx.snap
Expand Up @@ -53,7 +53,7 @@ exports[`single fields checkbox field 1`] = `
</form>
`;

exports[`single fields checkbox field 2`] = `
exports[`single fields checkbox field with label 1`] = `
<form
className="rjsf"
noValidate={false}
Expand Down Expand Up @@ -89,7 +89,7 @@ exports[`single fields checkbox field 2`] = `
/>
</span>
<span>

test
</span>
</label>
</div>
Expand Down