fix: export CJS version for browser

[MichaelDeBoey]

Just like @SimonB did with uuidjs/uuid#616

This will remove the necessity of having all the packages in transformIgnorePatterns in remix-run/remix#7220 or having them in moduleNameMapper in remix-run/react-router#9895

---

Closes #11
Closes remix-run/remix#3402

[changeset-bot]

🦋 Changeset detected

Latest commit: 1d4135d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@remix-run/web-blob	Minor
@remix-run/web-fetch	Minor
@remix-run/web-file	Minor
@remix-run/web-form-data	Minor
@remix-run/web-stream	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jacob-ebey]

@MichaelDeBoey explained to me that the ultimate issue here is when node is running in a jsdom env it attempts to load the browser export and therefore needs a CJS version as it doesn't fully support ESM yet.

[MichaelDeBoey]

For a more in depth explanation on what Jest is doing: have a look at microsoft/accessibility-insights-web#5421 (comment)

[brophdawg11]

👍 Looks like all the exports entries match up to npm pack --dry-run now. We may eventually want to align the fetch distributed package with the others, but that's a separate undertaking I think.

I think it's confusing how the others are currently building into dist/src while also including unbuilt src files in the package - so my vote would be to align everything to something like this in the published package:

dist/blob.cjs  // built CJS version
dist/lib.cjs   // built CJS version
src/blob.js    // raw ESM source file
src/lib.js     // raw ESM source file

Plus all .map files and .d.ts etc go in dist/

[brophdawg11]

@jacob-ebey Do you think this deserves a prerelease we can test against before we do the stable? Or are we comfortable publishing the stable? Remix uses caret dependencies for these so folks may pick them up as soon as they're published.

[MichaelDeBoey]

but that's a separate undertaking I think

Yeah I would do that in a follow-up PR if wanted

so my vote would be to align everything to something like this in the published package:

dist/blob.cjs  // built CJS version
dist/lib.cjs   // built CJS version
src/blob.js    // raw ESM source file
src/lib.js     // raw ESM source file

Plus all .map files and .d.ts etc go in dist/

Here blob is for browser & lib for node?

[brophdawg11]

@MichaelDeBoey Sorry I trimmed that for brevity. There would also be dist/blob.node.cjs/src/blob.node.js/etc file if it has node versions. The key is just that src/ is unbuilt files, and dist/ is build files and there is no longer a confusing dist/src/ folder.

[brophdawg11]

Should this be a minor since it's sort of adding a new feature in CJS files?

[MichaelDeBoey]

I went with patch as it not a real feature, but I can go with minor if you want

[brophdawg11]

ok - yeah I think it could go either way since there's no userland code API changes. Going to update to minor just to be safe since we're providing a new surface area for the bundler