Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Jest v29 #9895

Merged
merged 9 commits into from
Jan 19, 2023
Merged

chore: update to Jest v29 #9895

merged 9 commits into from
Jan 19, 2023

Conversation

timdorr
Copy link
Member

@timdorr timdorr commented Jan 12, 2023

Recreating @SimenB's #9253 because I'm not able to push with a merge from a different branch for some reason...

Anyways, this updates us to a newer Jest 29 setup and resolves any update conflicts or issues therein. You can read what Simen did in the original PR and this is just a continuation of that.

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2023

⚠️ No Changeset found

Latest commit: b694aff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@timdorr timdorr force-pushed the update-jest branch 2 times, most recently from 1a32aba to 2faf710 Compare January 12, 2023 18:31
@timdorr
Copy link
Member Author

timdorr commented Jan 12, 2023

OK, got rid of the extraneous commits, so this should be good to go 👍

@@ -9,6 +10,13 @@ module.exports = {
setupFiles: ["./__tests__/setup.ts"],
moduleNameMapper: {
"^@remix-run/router$": "<rootDir>/../router/index.ts",
"^@remix-run/web-blob$": require.resolve("@remix-run/web-blob"),
Copy link

@SimenB SimenB Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally you would provide CJS entry points for node browser and then we'd be able to avoid this. Right now there are both CJS and ESM entry points for node, but browser only has ESM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB I guess remix-run/web-std-io#43 is what you're referring to?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep 🙂

@brophdawg11 brophdawg11 self-assigned this Jan 16, 2023
@brophdawg11
Copy link
Contributor

Thanks for doing this @timdorr 🙌. I've been meaning to get to this now that 1.10 went out. I'll try to get this merged once we get the current release-next branch back down into dev

@timdorr
Copy link
Member Author

timdorr commented Jan 17, 2023

Cool. If there are conflicts, I can take care of them. I've still got my sed scripts in my terminal history.

@timdorr
Copy link
Member Author

timdorr commented Jan 18, 2023

Rebased on the latest dev. No conflicts and tests should be green. 👍

@brophdawg11
Copy link
Contributor

Thanks @SimenB and @timdorr!

@brophdawg11 brophdawg11 merged commit 1143652 into dev Jan 19, 2023
@brophdawg11 brophdawg11 deleted the update-jest branch January 19, 2023 16:22
@SimenB
Copy link

SimenB commented Jan 19, 2023

🎉

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.7.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants