fix: export CJS version for browser (#43)

remix-run · Sep 1, 2023 · 807fc63 · 807fc63
1 parent d3a1ffd
commit 807fc63
Show file tree

Hide file tree

Showing 7 changed files with 60 additions and 19 deletions.
diff --git a/.changeset/afraid-coats-rescue.md b/.changeset/afraid-coats-rescue.md
@@ -0,0 +1,9 @@
+---
+"@remix-run/web-blob": minor
+"@remix-run/web-fetch": minor
+"@remix-run/web-file": minor
+"@remix-run/web-form-data": minor
+"@remix-run/web-stream": minor
+---
+
+Export CJS version for browser
diff --git a/packages/blob/package.json b/packages/blob/package.json
@@ -19,7 +19,10 @@
   "exports": {
     ".": {
       "types": "./dist/src/lib.d.ts",
-      "browser": "./src/lib.js",
+      "browser": {
+        "require": "./dist/src/lib.cjs",
+        "import": "./src/lib.js"
+      },
       "require": "./dist/src/lib.node.cjs",
       "import": "./src/lib.node.js"
     }

diff --git a/packages/fetch/package.json b/packages/fetch/package.json
@@ -10,7 +10,10 @@
   "exports": {
     ".": {
       "types": "./dist/src/lib.node.d.ts",
-      "browser": "./src/lib.js",
+      "browser": {
+        "require": "./dist/lib.cjs",
+        "import": "./src/lib.js"
+      },
       "require": "./dist/lib.node.cjs",
       "import": "./src/lib.node.js"
     },

diff --git a/packages/fetch/rollup.config.js b/packages/fetch/rollup.config.js
@@ -1,18 +1,35 @@
 import {builtinModules} from 'module';
 import {dependencies} from './package.json';
 
-export default {
-	input: 'src/lib.node.js',
-	output: {
-		file: 'dist/lib.node.cjs',
-		format: 'cjs',
-		esModule: false,
-		interop: false,
-		sourcemap: true,
-		preferConst: true,
-		exports: 'named',
-		// https://github.com/rollup/rollup/issues/1961#issuecomment-534977678
-		outro: 'exports = module.exports = Object.assign(fetch, exports);'
+export default [
+	{
+		input: 'src/lib.js',
+		output: {
+			file: 'dist/lib.cjs',
+			format: 'cjs',
+			esModule: false,
+			interop: false,
+			sourcemap: true,
+			preferConst: true,
+			exports: 'named',
+			// https://github.com/rollup/rollup/issues/1961#issuecomment-534977678
+			outro: 'exports = module.exports = Object.assign(fetch, exports);'
+		},
+		external: [...builtinModules, ...Object.keys(dependencies)]
 	},
-	external: [...builtinModules, ...Object.keys(dependencies)]
-};
+	{
+		input: 'src/lib.node.js',
+		output: {
+			file: 'dist/lib.node.cjs',
+			format: 'cjs',
+			esModule: false,
+			interop: false,
+			sourcemap: true,
+			preferConst: true,
+			exports: 'named',
+			// https://github.com/rollup/rollup/issues/1961#issuecomment-534977678
+			outro: 'exports = module.exports = Object.assign(fetch, exports);'
+		},
+		external: [...builtinModules, ...Object.keys(dependencies)]
+	},
+];
diff --git a/packages/file/package.json b/packages/file/package.json
@@ -24,7 +24,10 @@
   "exports": {
     ".": {
       "types": "./dist/src/lib.d.ts",
-      "browser": "./src/lib.js",
+      "browser": {
+        "require": "./dist/src/lib.cjs",
+        "import": "./src/lib.js"
+      },
       "require": "./dist/src/lib.node.cjs",
       "node": "./src/lib.node.js"
     }

diff --git a/packages/form-data/package.json b/packages/form-data/package.json
@@ -22,7 +22,10 @@
   "exports": {
     ".": {
       "types": "./dist/src/lib.d.ts",
-      "browser": "./src/lib.js",
+      "browser": {
+        "require": "./dist/src/lib.cjs",
+        "import": "./src/lib.js"
+      },
       "require": "./dist/src/lib.node.cjs",
       "import": "./src/lib.node.js"
     }

diff --git a/packages/stream/package.json b/packages/stream/package.json
@@ -24,7 +24,10 @@
   "exports": {
     ".": {
       "types": "./src/lib.d.ts",
-      "browser": "./src/lib.js",
+      "browser": {
+        "require": "./src/stream.cjs",
+        "import": "./src/lib.js"
+      },
       "require": "./src/stream.cjs",
       "import": "./src/lib.node.js"
     }