Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XAUTOCLAIM to return the full response #2252

Merged
merged 2 commits into from Jun 27, 2022
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jun 27, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixes #2226

@dvora-h dvora-h added bug Bug breakingchange API or Breaking Change labels Jun 27, 2022
@dvora-h dvora-h requested a review from chayim June 27, 2022 09:21
@codecov-commenter
Copy link

Codecov Report

Merging #2252 (0f19548) into master (bedf3c8) will decrease coverage by 14.84%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #2252       +/-   ##
===========================================
- Coverage   91.83%   76.98%   -14.85%     
===========================================
  Files         108      108               
  Lines       27690    26913      -777     
===========================================
- Hits        25429    20720     -4709     
- Misses       2261     6193     +3932     
Impacted Files Coverage Δ
redis/client.py 87.90% <100.00%> (-0.76%) ⬇️
tests/test_commands.py 88.60% <100.00%> (-1.21%) ⬇️
tests/test_cluster.py 14.66% <0.00%> (-82.26%) ⬇️
tests/test_asyncio/test_cluster.py 18.62% <0.00%> (-79.02%) ⬇️
redis/asyncio/cluster.py 16.92% <0.00%> (-73.00%) ⬇️
redis/cluster.py 18.99% <0.00%> (-71.01%) ⬇️
redis/asyncio/parser.py 17.30% <0.00%> (-63.47%) ⬇️
redis/commands/cluster.py 32.10% <0.00%> (-62.11%) ⬇️
redis/crc.py 45.45% <0.00%> (-54.55%) ⬇️
tests/test_asyncio/test_connection.py 75.00% <0.00%> (-22.37%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedf3c8...0f19548. Read the comment docs.

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super tiny + clean. Nice!

@dvora-h dvora-h merged commit e85fe3b into redis:master Jun 27, 2022
andreasjansson added a commit to andreasjansson/cog that referenced this pull request Jun 28, 2022
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog.

This PR handles the new XAUTOCLAIM response format in a backwards-compatible way.

Closes replicate#671
andreasjansson added a commit to andreasjansson/cog that referenced this pull request Jun 28, 2022
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog.

This PR handles the new XAUTOCLAIM response format in a backwards-compatible way.

Closes replicate#671

Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson added a commit to replicate/cog that referenced this pull request Jun 28, 2022
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog.

This PR handles the new XAUTOCLAIM response format in a backwards-compatible way.

Closes #671

Signed-off-by: andreasjansson <andreas@replicate.ai>
@dvora-h dvora-h deleted the xautoclaim branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xautoclaim discards first reply part (id of last scanned stream item)
3 participants