Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis issue causing CI to fail #671

Closed
bfirsh opened this issue Jun 28, 2022 · 1 comment · Fixed by #672
Closed

Redis issue causing CI to fail #671

bfirsh opened this issue Jun 28, 2022 · 1 comment · Fixed by #672
Assignees
@andreasjansson
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bfirsh
Copy link
Member

bfirsh commented Jun 28, 2022

Logs are too long to display on GitHub actions but this is the error:

Failed to handle message: Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/cog/server/redis_queue.py", line 166, in start
    message_id, message_json = self.receive_message()
  File "/usr/local/lib/python3.8/site-packages/cog/server/redis_queue.py", line 128, in receive_message
    key, raw_message = raw_messages[0]
ValueError: too many values to unpack (expected 2)

I thought it might be that the redis 7 docker image was pushed a few days ago but pinning to redis:6 doesn't seem to fix it.
@bfirsh bfirsh added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 28, 2022
@andreasjansson
Copy link
Member

andreasjansson commented Jun 28, 2022 •
edited

This breaking change in redis==4.3.4 causes XAUTOCLAIM to return [b"0-0", []] instead of [] when the queue is empty.

@andreasjansson andreasjansson self-assigned this Jun 28, 2022
andreasjansson added a commit to andreasjansson/cog that referenced this issue Jun 28, 2022
@andreasjansson
Handle new XAUTOCLAIM response introduced in redis>=4.3.4
1a614a6 
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog.

This PR handles the new XAUTOCLAIM response format in a backwards-compatible way.

Closes replicate#671
@andreasjansson andreasjansson mentioned this issue Jun 28, 2022
Merged
andreasjansson added a commit to andreasjansson/cog that referenced this issue Jun 28, 2022
@andreasjansson
Handle new XAUTOCLAIM response introduced in redis>=4.3.4
1a5b375 
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog.

This PR handles the new XAUTOCLAIM response format in a backwards-compatible way.

Closes replicate#671

Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson added a commit that referenced this issue Jun 28, 2022
@andreasjansson
Handle new XAUTOCLAIM response introduced in redis>=4.3.4
9b6bb20 
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog.

This PR handles the new XAUTOCLAIM response format in a backwards-compatible way.

Closes #671

Signed-off-by: andreasjansson <andreas@replicate.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasjansson andreasjansson

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle new XAUTOCLAIM response introduced in redis>=4.3.4 andreasjansson/cog
2 participants
@bfirsh @andreasjansson