-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle new XAUTOCLAIM response introduced in redis>=4.3.4 #672
Handle new XAUTOCLAIM response introduced in redis>=4.3.4 #672
Conversation
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog. This PR handles the new XAUTOCLAIM response format in a backwards-compatible way. Closes replicate#671 Signed-off-by: andreasjansson <andreas@replicate.ai>
1a614a6
to
1a5b375
Compare
Looks good. Perhaps we should also pin The real fix: #409 |
This breaks all existing versions of Cog doesn't it? I guess this is a good reason to use #605 :) |
I decided against this since redis-py is used by a lot of other packages. But yeah, this is another reminder that we really should vendor dependencies. |
I wonder if they are going to be used in ML models though? |
Ray, Optuna, etc. It's probably as likely that any of the other packages we depend on introduce breaking changes. I think we should just get this issue fixed and then move to vendor our dependencies. |
100% all looks good. |
I made the update check display a message for #672 but the message doesn't reset when people upgrade. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
I made the update check display a message for #672 but the message doesn't reset when people upgrade. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
I made the update check display a message for #672 but the message doesn't reset when people upgrade. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
A breaking change in
redis==4.3.4
breaks Cog.This PR handles the new XAUTOCLAIM response format in a backwards-compatible way.
Closes #671