Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: Set the minimum redis-py version to 4.3.4 #541

Merged
merged 3 commits into from
Jul 13, 2022
Merged

setup: Set the minimum redis-py version to 4.3.4 #541

merged 3 commits into from
Jul 13, 2022

Conversation

achimnol
Copy link
Member

As a follow-up to #468, we need to set the minimum redis-py version to 4.3.4 because 4.3.3 and lower versions have different return values of the XAUTOCLAIM API wrapper.
(refs redis/redis-py#2252)

@achimnol achimnol added this to the 22.03 milestone Jul 13, 2022
@achimnol achimnol added comp:common Related to Common component type:maintenance Maintenance issue. area:upstream Issues with root cause from upstream 3rd parties labels Jul 13, 2022
@achimnol achimnol self-assigned this Jul 13, 2022
@achimnol achimnol modified the milestones: 22.03, 22.06 Jul 13, 2022
@achimnol achimnol requested a review from kyujin-cho July 13, 2022 02:56
kyujin-cho
kyujin-cho approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@kyujin-cho kyujin-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Yaminyam
Yaminyam approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@Yaminyam Yaminyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@achimnol achimnol merged commit 0c548d4 into main Jul 13, 2022
@achimnol achimnol deleted the feature/pin-redis-to-4.3.4-or-higher branch July 13, 2022 08:02
@Yaminyam Yaminyam added the size:L 100~500 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyujin-cho kyujin-cho kyujin-cho approved these changes

@Yaminyam Yaminyam Yaminyam approved these changes

Assignees

@achimnol achimnol

Labels
area:upstream Issues with root cause from upstream 3rd parties comp:common Related to Common component size:L 100~500 LoC type:maintenance Maintenance issue.
Projects
None yet
Milestone
22.06
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achimnol @kyujin-cho @Yaminyam