[PHP 8.1] Add ReturnNeverTypeRector #6283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
php81-never
branch
2 times, most recently
from
e543bf9
to
f7fd312
Compare
TomasVotruba
changed the title
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
php81-never
branch
6 times, most recently
from
908abe5
to
0c7d3ce
Compare
This was referenced May 21, 2021
1 task
staabm
reviewed
Jun 25, 2021
|
|
||
| final class DieSome | ||
| { | ||
| public function run(): never |
There was a problem hiding this comment.
when this rector would use @return never instead of the native return type, it would ease usage with php 7.x (without the need for a additional downgrading step) - would you accept a PR changing this rector from :never to @return never ?
There was a problem hiding this comment.
I think other rules also use @x alternative, unless the type is nativelly supported in PHP, so yes, go for it 👍
There was a problem hiding this comment.
here we go rectorphp/rector-src#296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6276