ReturnNeverTypeRector: use @return never for php7.x support

[clxmstaab]

this PR changes the ReturnNeverTypeRector to use @return never which can safely be used on php7.x

as discussed in rectorphp/rector#6283 (comment)

[clxmstaab]

@TomasVotruba this should be good to go

[TomasVotruba]

This one has lover priority, code samples should promote the highest PHP availble, if they're using native PHP feature. E.g. TypedPropertyRector uses native types, even though @var is possible too. But that was not the reason for making the rule. The original "why" should be respected

[clxmstaab]

E.g. TypedPropertyRector uses native types, even though @var is possible too. But that was not the reason for making the rule. The original "why" should be respected

so you mean when running this rector on php8 it should add :never but when running on php7.x it should add @return never, right?

[TomasVotruba]

Yes, the PHP version is configurable in config for the test case

[staabm]

rebased and green, which meens #306 fixed the underlying problem we saw initially. 👍

going back to the open issue:

This one has lover priority, code samples should promote the highest PHP availble, if they're using native PHP feature. E.g. TypedPropertyRector uses native types, even though @var is possible too. But that was not the reason for making the rule. The original "why" should be respected

is there another rector which I can take inspiration from, on how to separate the test-fixtures by php version?

[TomasVotruba]

is there another rector which I can take inspiration from, on how to separate the test-fixtures by php version?

Yes, look for files PHP<version>Test.php

[staabm]

just separated the PHP7.2 tests from the PHP8.1+ tests.

two remaining problems:

• we get some unrelated NodeRepository errors, which are unrelated to this PR (I guess this is related to latest changes on the main branch)
• I can see a single error locally, which doesn't reproduce in CI (and I don't know how to fix it):

$ vendor/bin/phpunit rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnNeverTypeRector/ReturnNeverTypeRectorTest.php
PHPUnit 9.5.6 by Sebastian Bergmann and contributors.

.......F.                                                           9 / 9 (100%)

Time: 00:02.602, Memory: 68.00 MB

There was 1 failure:

1) Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector\ReturnNeverTypeRectorTest::test with data set #5 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnNeverTypeRector/Fixture/skip_parent_protected.php.inc
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@

 final class SkipParentProtected implements SomeInterfaceWithReturnType
 {
-    public function run()
+    public function run(): never
     {
         throw new ShouldNotHappenException();
     }

C:\dvl\GitHub\rector-src-staabm\packages\Testing\PHPUnit\AbstractRectorTestCase.php:130
C:\dvl\GitHub\rector-src-staabm\packages\Testing\PHPUnit\AbstractRectorTestCase.php:92
C:\dvl\GitHub\rector-src-staabm\rules-tests\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector\ReturnNeverTypeRectorTest.php:18

FAILURES!
Tests: 9, Assertions: 19, Failures: 1.

feedback welcome

[staabm]

extracted a shouldSkip() to reduce refactor() complexity

[clxmstaab]

@TomasVotruba all green now after rebase ƪ(˘⌣˘)ʃ

[TomasVotruba]

Thank you, looks good 🙂 👍