add param types to configure()

rectorphp · May 2, 2021 · 62a3331 · 62a3331
1 parent 1e4dfbe
commit 62a3331
Show file tree

Hide file tree

Showing 33 changed files with 110 additions and 8 deletions.
diff --git a/rules/Arguments/Rector/ClassMethod/ArgumentDefaultValueReplacerRector.php b/rules/Arguments/Rector/ClassMethod/ArgumentDefaultValueReplacerRector.php
@@ -97,6 +97,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, ArgumentDefaultValueReplacer[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $replacedArguments = $configuration[self::REPLACED_ARGUMENTS] ?? [];

diff --git a/rules/Arguments/Rector/FuncCall/SwapFuncCallArgumentsRector.php b/rules/Arguments/Rector/FuncCall/SwapFuncCallArgumentsRector.php
@@ -95,6 +95,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, SwapFuncCallArguments[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $functionArgumentSwaps = $configuration[self::FUNCTION_ARGUMENT_SWAPS] ?? [];

diff --git a/rules/Defluent/Rector/ClassMethod/NormalToFluentRector.php b/rules/Defluent/Rector/ClassMethod/NormalToFluentRector.php
@@ -119,6 +119,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, NormalToFluent[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $callsToFluent = $configuration[self::CALLS_TO_FLUENT] ?? [];

diff --git a/rules/DependencyInjection/Rector/ClassMethod/AddMethodParentCallRector.php b/rules/DependencyInjection/Rector/ClassMethod/AddMethodParentCallRector.php
@@ -30,7 +30,7 @@ final class AddMethodParentCallRector extends AbstractRector implements Configur
     /**
      * @var array<string, string>
      */
-    private $methodsByParentTypes = [];
+    private $methodByParentTypes = [];
 
     public function getRuleDefinition(): RuleDefinition
     {
@@ -90,7 +90,7 @@ public function refactor(Node $node): ?Node
         /** @var string $className */
         $className = $node->getAttribute(AttributeKey::CLASS_NAME);
 
-        foreach ($this->methodsByParentTypes as $type => $method) {
+        foreach ($this->methodByParentTypes as $type => $method) {
             if (! $this->isObjectType($classLike, new ObjectType($type))) {
                 continue;
             }
@@ -112,9 +112,12 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, array<string, string>> $configuration
+     */
     public function configure(array $configuration): void
     {
-        $this->methodsByParentTypes = $configuration[self::METHODS_BY_PARENT_TYPES] ?? [];
+        $this->methodByParentTypes = $configuration[self::METHODS_BY_PARENT_TYPES] ?? [];
     }
 
     private function shouldSkipMethod(ClassMethod $classMethod, string $method): bool

diff --git a/rules/Php71/Rector/Name/ReservedObjectRector.php b/rules/Php71/Rector/Name/ReservedObjectRector.php
@@ -27,7 +27,7 @@ final class ReservedObjectRector extends AbstractRector implements ConfigurableR
     public const RESERVED_KEYWORDS_TO_REPLACEMENTS = 'reserved_keywords_to_replacements';
 
     /**
-     * @var string[]
+     * @var array<string, string>
      */
     private $reservedKeywordsToReplacements = [];
 
@@ -78,6 +78,9 @@ public function refactor(Node $node): ?Node
         return $this->processName($node);
     }
 
+    /**
+     * @param array<string, array<string, string>> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->reservedKeywordsToReplacements = $configuration[self::RESERVED_KEYWORDS_TO_REPLACEMENTS] ?? [];

diff --git a/rules/Php74/Rector/Function_/ReservedFnFunctionRector.php b/rules/Php74/Rector/Function_/ReservedFnFunctionRector.php
@@ -104,6 +104,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, array<string, string>> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->reservedNamesToNewOnes = $configuration[self::RESERVED_NAMES_TO_NEW_ONES] ?? [];

diff --git a/rules/Removing/Rector/ClassMethod/ArgumentRemoverRector.php b/rules/Removing/Rector/ClassMethod/ArgumentRemoverRector.php
@@ -86,6 +86,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, ArgumentRemover[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $removedArguments = $configuration[self::REMOVED_ARGUMENTS] ?? [];

diff --git a/rules/Removing/Rector/Class_/RemoveInterfacesRector.php b/rules/Removing/Rector/Class_/RemoveInterfacesRector.php
@@ -22,7 +22,7 @@ final class RemoveInterfacesRector extends AbstractRector implements Configurabl
     public const INTERFACES_TO_REMOVE = 'interfaces_to_remove';
 
     /**
-     * @var string[]
+     * @var class-string[]
      */
     private $interfacesToRemove = [];
 
@@ -75,6 +75,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, class-string[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->interfacesToRemove = $configuration[self::INTERFACES_TO_REMOVE] ?? [];

diff --git a/rules/Removing/Rector/Class_/RemoveTraitRector.php b/rules/Removing/Rector/Class_/RemoveTraitRector.php
@@ -99,6 +99,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, string[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->traitsToRemove = $configuration[self::TRAITS_TO_REMOVE] ?? [];

diff --git a/rules/Removing/Rector/FuncCall/RemoveFuncCallArgRector.php b/rules/Removing/Rector/FuncCall/RemoveFuncCallArgRector.php
@@ -80,6 +80,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, RemoveFuncCallArg[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $removedFunctionArguments = $configuration[self::REMOVED_FUNCTION_ARGUMENTS] ?? [];

diff --git a/rules/RemovingStatic/Rector/Class_/StaticTypeToSetterInjectionRector.php b/rules/RemovingStatic/Rector/Class_/StaticTypeToSetterInjectionRector.php
@@ -36,7 +36,7 @@ final class StaticTypeToSetterInjectionRector extends AbstractRector implements
     public const STATIC_TYPES = 'static_types';
 
     /**
-     * @var string[]
+     * @var array<class-string|int, class-string>
      */
     private $staticTypes = [];
 
@@ -134,6 +134,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, array<class-string|int, class-string>> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->staticTypes = $configuration[self::STATIC_TYPES] ?? [];

diff --git a/rules/Renaming/Rector/ClassMethod/RenameAnnotationRector.php b/rules/Renaming/Rector/ClassMethod/RenameAnnotationRector.php
@@ -117,6 +117,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, RenameAnnotation[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $renamedAnnotationsInTypes = $configuration[self::RENAMED_ANNOTATIONS_IN_TYPES] ?? [];

diff --git a/rules/Renaming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector.php b/rules/Renaming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector.php
@@ -122,6 +122,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, PseudoNamespaceToNamespace[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $namespacePrefixesWithExcludedClasses = $configuration[self::NAMESPACE_PREFIXES_WITH_EXCLUDED_CLASSES] ?? [];

diff --git a/rules/Renaming/Rector/PropertyFetch/RenamePropertyRector.php b/rules/Renaming/Rector/PropertyFetch/RenamePropertyRector.php
@@ -73,6 +73,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, RenameProperty[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $renamedProperties = $configuration[self::RENAMED_PROPERTIES] ?? [];

diff --git a/rules/Renaming/Rector/StaticCall/RenameStaticMethodRector.php b/rules/Renaming/Rector/StaticCall/RenameStaticMethodRector.php
@@ -13,6 +13,7 @@
 use Rector\Renaming\ValueObject\RenameStaticMethod;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\Renaming\Rector\StaticCall\RenameStaticMethodRector\RenameStaticMethodRectorTest
@@ -90,9 +91,14 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, RenameStaticMethod[]> $configuration
+     */
     public function configure(array $configuration): void
     {
-        $this->staticMethodRenames = $configuration[self::OLD_TO_NEW_METHODS_BY_CLASSES] ?? [];
+        $oldToNewMethodsByClasses = $configuration[self::OLD_TO_NEW_METHODS_BY_CLASSES];
+        Assert::allIsInstanceOf($oldToNewMethodsByClasses, RenameStaticMethod::class);
+        $this->staticMethodRenames = $oldToNewMethodsByClasses;
     }
 
     private function rename(StaticCall $staticCall, RenameStaticMethod $renameStaticMethod): StaticCall

diff --git a/rules/Restoration/Rector/New_/CompleteMissingDependencyInNewRector.php b/rules/Restoration/Rector/New_/CompleteMissingDependencyInNewRector.php
@@ -127,6 +127,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, array<class-string, class-string>> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->classToInstantiateByType = $configuration[self::CLASS_TO_INSTANTIATE_BY_TYPE] ?? [];

diff --git a/rules/Transform/Rector/Assign/DimFetchAssignToMethodCallRector.php b/rules/Transform/Rector/Assign/DimFetchAssignToMethodCallRector.php
@@ -112,6 +112,9 @@ public function refactor(Node $node): ?Node
         return new MethodCall($arrayDimFetch->var, $dimFetchAssignToMethodCall->getAddMethod(), $node->expr->args);
     }
 
+    /**
+     * @param array<string, DimFetchAssignToMethodCall[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $dimFetchAssignToMethodCalls = $configuration[self::DIM_FETCH_ASSIGN_TO_METHOD_CALL] ?? [];

diff --git a/rules/Transform/Rector/Assign/PropertyAssignToMethodCallRector.php b/rules/Transform/Rector/Assign/PropertyAssignToMethodCallRector.php
@@ -94,6 +94,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, PropertyAssignToMethodCall[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $propertyAssignsToMethodCalls = $configuration[self::PROPERTY_ASSIGNS_TO_METHODS_CALLS] ?? [];

diff --git a/rules/Transform/Rector/ClassMethod/WrapReturnRector.php b/rules/Transform/Rector/ClassMethod/WrapReturnRector.php
@@ -94,6 +94,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, WrapReturn[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $typeMethodWraps = $configuration[self::TYPE_METHOD_WRAPS] ?? [];

diff --git a/rules/Transform/Rector/Class_/MergeInterfacesRector.php b/rules/Transform/Rector/Class_/MergeInterfacesRector.php
@@ -28,7 +28,7 @@ final class MergeInterfacesRector extends AbstractRector implements Configurable
     public const OLD_TO_NEW_INTERFACES = 'old_to_new_interfaces';
 
     /**
-     * @var string[]
+     * @var array<string, string>
      */
     private $oldToNewInterfaces = [];
 
@@ -89,6 +89,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, array<string, string>> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->oldToNewInterfaces = $configuration[self::OLD_TO_NEW_INTERFACES] ?? [];

diff --git a/rules/Transform/Rector/Expression/MethodCallToReturnRector.php b/rules/Transform/Rector/Expression/MethodCallToReturnRector.php
@@ -95,6 +95,9 @@ public function refactor(Node $node): ?Node
         return $this->refactorMethodCall($methodCall);
     }
 
+    /**
+     * @param array<string, MethodCallToReturn[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $methodCallWraps = $configuration[self::METHOD_CALL_WRAPS] ?? [];

diff --git a/rules/Transform/Rector/FuncCall/FuncCallToConstFetchRector.php b/rules/Transform/Rector/FuncCall/FuncCallToConstFetchRector.php
@@ -86,6 +86,9 @@ public function refactor(Node $node): ?Node
         return new ConstFetch(new Name($this->functionsToConstants[$functionName]));
     }
 
+    /**
+     * @param array<string, string[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->functionsToConstants = $configuration[self::FUNCTIONS_TO_CONSTANTS] ?? [];

diff --git a/rules/Transform/Rector/FuncCall/FuncCallToStaticCallRector.php b/rules/Transform/Rector/FuncCall/FuncCallToStaticCallRector.php
@@ -71,6 +71,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, FuncCallToStaticCall[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $funcCallsToStaticCalls = $configuration[self::FUNC_CALLS_TO_STATIC_CALLS] ?? [];

diff --git a/rules/Transform/Rector/Isset_/UnsetAndIssetToMethodCallRector.php b/rules/Transform/Rector/Isset_/UnsetAndIssetToMethodCallRector.php
@@ -88,6 +88,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, UnsetAndIssetToMethodCall[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $issetUnsetToMethodCalls = $configuration[self::ISSET_UNSET_TO_METHOD_CALL] ?? [];

diff --git a/rules/Transform/Rector/MethodCall/MethodCallToAnotherMethodCallWithArgumentsRector.php b/rules/Transform/Rector/MethodCall/MethodCallToAnotherMethodCallWithArgumentsRector.php
@@ -84,6 +84,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, MethodCallToAnotherMethodCallWithArguments[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $methodCallRenamesWithAddedArguments = $configuration[self::METHOD_CALL_RENAMES_WITH_ADDED_ARGUMENTS] ?? [];

diff --git a/rules/Transform/Rector/MethodCall/MethodCallToPropertyFetchRector.php b/rules/Transform/Rector/MethodCall/MethodCallToPropertyFetchRector.php
@@ -84,6 +84,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, array<string, string>> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->methodCallToPropertyFetchCollection = $configuration[self::METHOD_CALL_TO_PROPERTY_FETCHES] ?? [];

diff --git a/rules/Transform/Rector/MethodCall/MethodCallToStaticCallRector.php b/rules/Transform/Rector/MethodCall/MethodCallToStaticCallRector.php
@@ -107,6 +107,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, MethodCallToStaticCall[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $methodCallsToStaticCalls = $configuration[self::METHOD_CALLS_TO_STATIC_CALLS] ?? [];

diff --git a/rules/Transform/Rector/MethodCall/ReplaceParentCallByPropertyCallRector.php b/rules/Transform/Rector/MethodCall/ReplaceParentCallByPropertyCallRector.php
@@ -91,6 +91,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, ReplaceParentCallByPropertyCall[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $this->parentCallToProperties = $configuration[self::PARENT_CALLS_TO_PROPERTIES] ?? [];

diff --git a/rules/Transform/Rector/MethodCall/ServiceGetterToConstructorInjectionRector.php b/rules/Transform/Rector/MethodCall/ServiceGetterToConstructorInjectionRector.php
@@ -176,6 +176,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, ServiceGetterToConstructorInjection[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $methodCallToServices = $configuration[self::METHOD_CALL_TO_SERVICES] ?? [];

diff --git a/rules/Transform/Rector/New_/NewToStaticCallRector.php b/rules/Transform/Rector/New_/NewToStaticCallRector.php
@@ -87,6 +87,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, NewToStaticCall[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $typeToStaticCalls = $configuration[self::TYPE_TO_STATIC_CALLS] ?? [];

diff --git a/rules/Transform/Rector/StaticCall/StaticCallToFuncCallRector.php b/rules/Transform/Rector/StaticCall/StaticCallToFuncCallRector.php
@@ -81,6 +81,9 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    /**
+     * @param array<string, StaticCallToFuncCall[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $staticCallsToFunctions = $configuration[self::STATIC_CALLS_TO_FUNCTIONS] ?? [];

diff --git a/rules/Transform/Rector/String_/StringToClassConstantRector.php b/rules/Transform/Rector/String_/StringToClassConstantRector.php
@@ -88,6 +88,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    /**
+     * @param array<string, StringToClassConstant[]> $configuration
+     */
     public function configure(array $configuration): void
     {
         $stringToClassConstants = $configuration[self::STRINGS_TO_CLASS_CONSTANTS] ?? [];