Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setMethods call has been removed in PHPUnit 10 #293

Merged
merged 1 commit into from Nov 10, 2023

Conversation

bbrala
Copy link
Contributor

@bbrala bbrala commented Nov 10, 2023

Deprecated in PPHPUnit 8.3 see: sebastianbergmann/phpunit@d618fa3

Fixes #292

@TomasVotruba
Copy link
Member

Thank you 👏

@TomasVotruba TomasVotruba enabled auto-merge (squash) November 10, 2023 15:54
@TomasVotruba TomasVotruba merged commit 808d4e2 into rectorphp:main Nov 10, 2023
5 checks passed
@samsonasik
Copy link
Member

@bbrala @TomasVotruba it seems the namespace need to be moved as well to avoid notice on rector-src:

bin/rector missing-in-set --ansi

We could not find there rules in configs
========================================

 * vendor/rector/rector-phpunit/config/sets/phpunit-code-quality.php

 * Rector\PHPUnit\CodeQuality\Rector\MethodCall\RemoveSetMethodsMethodCallRector

see https://github.com/rectorphp/rector-src/actions/runs/6828589747/job/18573042345?pr=5239#step:5:15

I temporary register to skipped rules to check on MissingInSetCommand

rectorphp/rector-src@6b4ca21

@bbrala
Copy link
Contributor Author

bbrala commented Nov 11, 2023

Oh you are right.

Made a PR with the fix: #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing deprecation from phpunit 10?
3 participants