Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoveSetMethodsMethodCallRector: move tests and classes to new location #294

Merged
merged 2 commits into from
Nov 11, 2023
Merged

RemoveSetMethodsMethodCallRector: move tests and classes to new location #294

merged 2 commits into from
Nov 11, 2023

Conversation

bbrala
Copy link
Contributor

@bbrala bbrala commented Nov 11, 2023

Move RemoveSetMethodsMethodCallRector and its tests to correct namespace.

As per: #293 (comment)

@bbrala bbrala mentioned this pull request Nov 11, 2023
Merged
@bbrala
Copy link
Contributor Author

bbrala commented Nov 11, 2023

Failure is because the branch is not in main repo i think?

@samsonasik
Copy link
Member

You can run:

vendor/bin/rector && vendor/bin/ecs check --fix

to make CI green

@bbrala
Copy link
Contributor Author

bbrala commented Nov 11, 2023

Ty will do

@samsonasik
Copy link
Member

Thank you @bbrala let's give it a try 👍

@samsonasik samsonasik merged commit 9d85ec1 into rectorphp:main Nov 11, 2023
5 checks passed
@samsonasik samsonasik mentioned this pull request Nov 11, 2023
Merged
@samsonasik
Copy link
Member

samsonasik commented Nov 11, 2023 •
edited

it seems working ok now 👍 , see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbrala @samsonasik