Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Handle repetitive jump equal case stmts on RemoveDuplicatedCaseInSwitchRector #5239

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik
Copy link
Member Author

Fixed 🎉

Comment on lines +42 to +44

// namespace to be moved from CodeQuality to PHPUnit100
RemoveSetMethodsMethodCallRector::class,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomasVotruba this is added here temporary due to rector-phpunit PR for move RemoveSetMethodsMethodCallRector from phpunit code-quality to phpunit 100

to avoid notice:

bin/rector missing-in-set --ansi

We could not find there rules in configs
========================================

 * vendor/rector/rector-phpunit/config/sets/phpunit-code-quality.php

 * Rector\PHPUnit\CodeQuality\Rector\MethodCall\RemoveSetMethodsMethodCallRector

@samsonasik samsonasik closed this Nov 10, 2023
@samsonasik samsonasik reopened this Nov 10, 2023
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 2f74b02 into main Nov 10, 2023
82 checks passed
@samsonasik samsonasik deleted the handle-indirect-multiple branch November 10, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant