Add lower bound to Listen gem requirement #48622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
activesupport/lib/active_support/evented_file_update_checker.rb
Outdated
Show resolved
Hide resolved
An issue was recently opened with the following error message: ``` .../activesupport-7.0.6/lib/active_support/evented_file_update_checker.rb:120:in `start': undefined method `wait_for_state' for #<Listen::Listener ...> ``` The issue is that the user was using Listen 3.0.8, however the `wait_for_state` method was [added][1] in Listen 3.3.0 We can make the error message a little better by defining a lower bound on Listen 3.3.0 (like we do for other optional dependencies): ``` .../bundler/rubygems_integration.rb:280:in `block (2 levels) in replace_gem': can't activate listen (~> 3.3), already activated listen-3.0.8. Make sure all dependencies are added to Gemfile. (Gem::LoadError) ``` There is definitely still room for improvement here, but this should be much more helpful in figuring out that the issue is a bad Listen version and not a bug in Rails. [1]: guard/listen@12b4fc5
skipkayhil
force-pushed
the
hm-listen-lower-bound
branch
from
fe406b4
to
f311725
Compare
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Ref #48620
An issue was recently opened with the following error message:
The issue is that the user was using Listen 3.0.8, however the
wait_for_statemethod was added in Listen 3.3.0Detail
We can make the error message a little better by defining a lower bound on Listen 3.3.0 (like we do for other optional dependencies):
There is definitely still room for improvement here, but this should be much more helpful in figuring out that the issue is a bad Listen version and not a bug in Rails.
Additional Information
If this is backport worthy, we would need to backport #47002 as well
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]